Bug 466953 (perl-NOCpulse-Utils)
| Summary: | Review Request: perl-NOCpulse-Utils - NOCpulse utility packages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cweyl, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-16 09:22:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 452450 | ||
|
Description
Miroslav Suchý
2008-10-14 18:14:17 UTC
Hmm, interesting. Since we (Fedora) appear to be upstream, why not include a Makefile.PL setup? This would allow this package to be consistent with the zillions of other Perl package out there, and make everyone's tasks way easier over the long run :-) (See, e.g., Module::Install for a quick, easy, modern way to setup the standard Perl module build/test/install framework.) Patches are welcome. This is not my priority right now. But certainly on some TODO list, but not sure how deep :) Updated SPEC: http://miroslav.suchy.cz/fedora/perl-NOCpulse-Utils/perl-NOCpulse-Utils.spec SRPM: http://miroslav.suchy.cz/fedora/perl-NOCpulse-Utils/perl-NOCpulse-Utils-1.14.10-1.src.rpm Is there some reason why the included unit tests are not run?
I don't see any particular reason why building like any other Perl module would be a requirement, although it would certainly be useful.
Is there some reason %{perl_vendorlib}/NOCpulse/ isn't owned by this package? It is normal for Perl modules to do this, and the situation is explicitly described in http://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
> Is there some reason why the included unit tests are not run? Because the tests are archaic and do not even compile. The only reason why do not delete them completely is because I want to be rewritten later and make them run again. > Is there some reason %{perl_vendorlib}/NOCpulse/ isn't owned by this package? I thought there is automatic dependance on nocpulse-common, but this is one of few packages which do not require it. Will fix it. Ough I updated spec, but forgot to update this BZ :( Updated Spec: http://miroslav.suchy.cz/fedora/perl-NOCpulse-Utils/perl-NOCpulse-Utils.spec Update SRPM: http://miroslav.suchy.cz/fedora/perl-NOCpulse-Utils/perl-NOCpulse-Utils-1.14.11-1.src.rpm OK source files match upstream: fc962eb4a529f467911494d9d508512f OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package isn't need. OK rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. The installation is ugly as was mentioned before. But this is not blocker for a review according to guidelines. New Package CVS Request ======================= Package Name: perl-NOCpulse-Utils Short Description: NOCpulse utility packages Owners: msuchy Branches: F-10, EL-4, EL-5 InitialCC: perl-sig cvs done. |