Bug 467180
| Summary: | Review Request: pngnq - tool for quantizing PNG images in RGBA format Version | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gerd Hoffmann <kraxel> | ||||
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, julian.fedora, notting, oget.fedora, tcallawa | ||||
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-11-06 11:34:24 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Gerd Hoffmann
2008-10-16 08:48:45 UTC
Created attachment 320530 [details]
License text
Dunno how to categorize this license, to me it looks like based on zlib and mixed in something bsd-ish. Suggestions?
Yes it is a mixture of both. Most probably, since both are "good" licenses this package can go with Fedora. To make sure and to ask about naming the license, please send an email to the Fedora Legal mailing list. Other than the license issue a few other things need to be sorted out: * Although it is an almost obsolete field I think the Group should be Applications/Multimedia ? You can do a make all to build pngcomp in addition to pngnq and then package it together :) (Don't forget to include the other README file if you do this) * We recommend %defattr(-,root,root,-) * It would be nice if you briefly explain in the SPEC file what the patches do. Did you submit them upstream (especially the getopt patch)? If so, please provide the links (in the SPEC file) to their tracking system. * Package does not honor Fedora specific compilation flags. Please see: http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags -- Also, let's keep FE-Legal blocked until the license issue is solved. Uploaded new package release to the same location. Wrote email to fedora-legal. Three licenses in play here (in order) BSD with advertising MIT BSD So, License: BSD with advertising and MIT and BSD Lifting FE-Legal. New package with updated License: tag uploaded. * Make use of the %{version} macro for future convenience, e.g.
%setup -q -n %{version}
* Any information about the patches?
* In your SPEC file notation I think it would be better to use %{optflags} instead of ${RPM_OPT_FLAGS} .
* Please provide the links to the new SPEC and SRPM on every update, so things don't get mixed up.
Revision #5 uploaded: http://kraxel.fedorapeople.org/osm/pngnq/pngnq.spec http://kraxel.fedorapeople.org/osm/pngnq/pngnq-0.5-5.fc10.src.rpm Added patch comments, fixed up macro usage. Thank you. ---------------------------------------- This package (pngnq) is approved by oget ---------------------------------------- New Package CVS Request ======================= Package Name: pngnq Short Description: tool for quantizing PNG images in RGBA format Owners: kraxel Branches: F-9 InitialCC: cvs done. committed & built now. *** Bug 513619 has been marked as a duplicate of this bug. *** |