Bug 467325 (mingw32-iconv)

Spec URL: http://www.annexia.org/tmp/mingw32-iconv.spec
SRPM URL: http://www.annexia.org/tmp/mingw32-iconv-1.12-5.fc10.src.rpm

* Mon Nov  3 2008 Richard W.M. Jones <rjones> - 0.17-5
- Changed the summary (Bruno Haible).
- Note about mingw32-gettext / Remove *.mo files.

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/iconv/mingw32-iconv.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-iconv-1.12-5.fc10.src.rpm

Only issue is the license isn't included.

+ rpmlint output

rpmlint -i mingw32-iconv-1.12-5.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license

- %doc includes license file
  no license file included
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  c2be282595751535a618ae0edeb8f648  libiconv-1.12.tar.gz
+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin

Thanks for looking at all these.

Here's an updated version with the license files included:

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/iconv/mingw32-iconv.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-iconv-1.12-7.fc10.src.rpm

* Fri Dec 19 2008 Richard W.M. Jones <rjones> - 1.12-7               
- Include the license files in doc section.                                     
- Fix the changelog entry numbering.

APPROVED!

New Package CVS Request
=======================
Package Name: mingw32-iconv
Short Description: GNU libraries and utilities for character set conversion
Owners: rjones berrange lfarkas
Branches: EL-5 F-10
InitialCC:

cvs done.

Thanks Peter and Kevin.

Imported and built.