Bug 467389 (mingw32-pthreads)

Summary:	Review Request: mingw32-pthreads - MinGW pthread library
Product:	[Fedora] Fedora	Reporter:	Richard W.M. Jones <rjones>
Component:	Package Review	Assignee:	Levente Farkas <lfarkas>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	berrange, fedora-package-review, kwizart, lfarkas, notting
Target Milestone:	---	Flags:	lfarkas: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-01-14 10:07:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	454410
Bug Blocks:

Description Richard W.M. Jones 2008-10-17 09:32:00 UTC

Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=82a0662b5376fe1a90612ed85628670c902a43d3;path=/pthreads/
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-pthreads-2.8.0-2.fc9.src.rpm
Description:
Win32 does not, and is unlikely to ever, support pthreads
natively. This project seeks to provide a freely available and
high-quality solution to this problem.

Approved MinGW packaging guidelines are here:
http://fedoraproject.org/wiki/Packaging/MinGW

Comment 1 Levente Farkas 2008-12-02 21:36:50 UTC

replace %{crazy_version} with 
`echo %{version}|tr . -`
it's much easier to see in place and don't have to change when the version change (although it's not changed for years)

in the build section put the clean after the first build:
make CROSS=%{_mingw32_host}- GC-inlined
make clean
make CROSS=%{_mingw32_host}- GCE-inlined
afais GCE-inlined has different defines so probably a clean would be
useful before the next target.

add -mms-bitfields or even better %_mingw32_cflags to OPT probably only
way to do this is a patch for the makefile.

Comment 2 Richard W.M. Jones 2008-12-10 16:28:18 UTC

In reply to comment 1, see
http://lists.fedoraproject.org/pipermail/fedora-mingw/2008-December/000211.html

Comment 3 Richard W.M. Jones 2008-12-10 16:28:51 UTC

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/pthreads/mingw32-pthreads.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-pthreads-2.8.0-2.fc10.src.rpm

Comment 4 Levente Farkas 2009-01-11 15:44:21 UTC

the latest mercurial spec file and patchs are good.

 This package (mingw32-pthreads) is APPROVED by lfarkas

Comment 5 Richard W.M. Jones 2009-01-13 10:54:10 UTC

I made some small (non-functional) cleanups to the spec file
and did a scratch-build in Koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1049150

Comment 6 Richard W.M. Jones 2009-01-13 10:55:50 UTC

New Package CVS Request
=======================
Package Name: mingw32-pthreads
Short Description: MinGW pthread library
Owners: rjones berrange lfarkas
Branches: F-10 EL-5
InitialCC:

Comment 7 Kevin Fenzi 2009-01-13 20:35:25 UTC

cvs done.

Comment 8 Richard W.M. Jones 2009-01-14 10:07:51 UTC

Thanks everyone for helping out with this.

It's now built in EL-5, F-10 and Rawhide.

Comment 9 Fedora Update System 2009-01-14 10:10:39 UTC

mingw32-pthreads-2.8.0-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-pthreads-2.8.0-4.fc10

Comment 10 Fedora Update System 2009-01-15 02:55:24 UTC

mingw32-pthreads-2.8.0-4.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.