Bug 467389 (mingw32-pthreads) - Review Request: mingw32-pthreads - MinGW pthread library
Summary: Review Request: mingw32-pthreads - MinGW pthread library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: mingw32-pthreads
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Levente Farkas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 454410
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-17 09:32 UTC by Richard W.M. Jones
Modified: 2009-01-15 02:55 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-14 10:07:51 UTC
Type: ---
Embargoed:
lfarkas: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Richard W.M. Jones 2008-10-17 09:32:00 UTC
Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=82a0662b5376fe1a90612ed85628670c902a43d3;path=/pthreads/
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-pthreads-2.8.0-2.fc9.src.rpm
Description:
Win32 does not, and is unlikely to ever, support pthreads
natively. This project seeks to provide a freely available and
high-quality solution to this problem.

Approved MinGW packaging guidelines are here:
http://fedoraproject.org/wiki/Packaging/MinGW

Comment 1 Levente Farkas 2008-12-02 21:36:50 UTC
replace %{crazy_version} with 
`echo %{version}|tr . -`
it's much easier to see in place and don't have to change when the version change (although it's not changed for years)

in the build section put the clean after the first build:
make CROSS=%{_mingw32_host}- GC-inlined
make clean
make CROSS=%{_mingw32_host}- GCE-inlined
afais GCE-inlined has different defines so probably a clean would be
useful before the next target.

add -mms-bitfields or even better %_mingw32_cflags to OPT probably only
way to do this is a patch for the makefile.

Comment 4 Levente Farkas 2009-01-11 15:44:21 UTC
the latest mercurial spec file and patchs are good.

 This package (mingw32-pthreads) is APPROVED by lfarkas

Comment 5 Richard W.M. Jones 2009-01-13 10:54:10 UTC
I made some small (non-functional) cleanups to the spec file
and did a scratch-build in Koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1049150

Comment 6 Richard W.M. Jones 2009-01-13 10:55:50 UTC
New Package CVS Request
=======================
Package Name: mingw32-pthreads
Short Description: MinGW pthread library
Owners: rjones berrange lfarkas
Branches: F-10 EL-5
InitialCC:

Comment 7 Kevin Fenzi 2009-01-13 20:35:25 UTC
cvs done.

Comment 8 Richard W.M. Jones 2009-01-14 10:07:51 UTC
Thanks everyone for helping out with this.

It's now built in EL-5, F-10 and Rawhide.

Comment 9 Fedora Update System 2009-01-14 10:10:39 UTC
mingw32-pthreads-2.8.0-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-pthreads-2.8.0-4.fc10

Comment 10 Fedora Update System 2009-01-15 02:55:24 UTC
mingw32-pthreads-2.8.0-4.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.