Bug 467408 (mingw32-jasper)
| Summary: | Review Request: mingw32-jasper - MinGW Windows Jasper library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
| Component: | Package Review | Assignee: | Erik van Pienbroek <erik-fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | berrange, erik-fedora, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | erik-fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.900.1-8.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-16 19:42:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 454410, 467401 | ||
| Bug Blocks: | 467420 | ||
|
Description
Richard W.M. Jones
2008-10-17 11:13:08 UTC
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/jasper/mingw32-jasper.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-jasper-1.900.1-5.fc10.src.rpm Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/jasper/mingw32-jasper.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-jasper-1.900.1-6.fc11.src.rpm * Fri Jan 23 2009 Richard W.M. Jones <rjones> - 1.900.1-6 - Use _smp_mflags. - Disable static libraries. - Include documentation. - Use the same patches as Fedora native package. - Just run autoconf instead of autoreconf so we don't upgrade libtool. - +BR mingw32-dlfcn. - Don't need the manual pages. This review is done for the -7 release which is on the annexia.org webserver. - The %defattr line must be %defattr(-,root,root,-) - The purpose of the patches (or upstream bugreport) should be mentioned in the .spec file - The patch 'jasper-1.701.0-GL.patch' has no effect as OpenGL support is disabled using a ./configure flag - According to http://www.nondot.org/sabre/Mirrored/libtool-2.1a/libtool_5.html, the AM_DISABLE_SHARED macro is used for setting the default behaviour for building shared libraries. "The user may still override this default by specifying `--enable-shared'". So it should be sufficient to drop the 'jasper-1.900.1-mingw32.patch' patch and use '--enable shared' as ./configure flag. - The patch 'jasper-1.900.1-mingw32.patch' can be simplified by only adjusting the Makefile.in. This prevents having to use autoconf while still archieving the same effect Spec URL: http://www.annexia.org/tmp/mingw32-jasper.spec SRPM URL: http://www.annexia.org/tmp/mingw32-jasper-1.900.1-8.fc11.src.rpm * Mon Mar 9 2009 Richard W.M. Jones <rjones> - 1.900.1-8 - Fix defattr line. - Remove the enable-shared patch, and just use --enable-shared on the configure line. - Disable the GL patch since OpenGL is disabled. - Document what the patches are for in the spec file. - Only patch Makefile.in so we don't have to rerun autotools, and remove autotools dependency. Looks good. There's just a small rpmlint warning remaining which you might want to look into: mingw32-jasper.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libjasper.dll.a Anyway, ==================================================== The package mingw32-jasper is approved by epienbro ==================================================== New Package CVS Request ======================= Package Name: mingw32-jasper Short Description: MinGW Jasper library Owners: rjones berrange epienbro Branches: F-10 EL-5 InitialCC: cvs done. mingw32-jasper-1.900.1-8.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-jasper-1.900.1-8.fc10 mingw32-jasper-1.900.1-8.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |