Bug 467643
| Summary: | Review Request: sugar-speak - Speak for Sugar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Bryan Kearney <bkearney> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkearney, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bkearney:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-15 02:53:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 462625 | ||
|
Description
Fabian Affolter
2008-10-19 21:59:32 UTC
See items below: OK - Package name XX - License info is accurate License is GPLv3 OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used ?? - Source md5sum matches upstream - Barring a "release" from upstream, can you export the source code usig the fixed snapshot url (http://dev.laptop.org/git?p=activities/speak;a=snapshot;h=f76cea50b0fdee97e92ce94ac379155d6f8d52ac) OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent ?? - rpmlint is silent - rpmlint on the srpm shows this (the last 3 are worriesome) sugar-maze.src: W: non-standard-group Sugar/Activities sugar-maze.src: W: strange-permission sugar-maze-checkout.sh 0755 sugar-maze.src: W: strange-permission Maze-6.tar.bz2 0755 sugar-maze.src: W: strange-permission sugar-maze.spec 0755 (In reply to comment #1) > sugar-maze.src: W: non-standard-group Sugar/Activities Copy-and-paste error? ;-) Anyway, the permission of the file from comment #1 are fixed Can you re-post the spec file and srcrpm with the new licens info. If I can see those I can approve (Speak is GPLv3) Sorry, I didn't upload a new version. After a new check of the license. The license is GPLv3+. COPYING says GPLv3, the file headers says "either version 3 of the License, or (at your option) any later version" Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-speak.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-speak-9-2.fc10.src.rpm Bryan, don't go ahead with this review.
For this package 'mkdir -p %{buildroot}/%{sugaractivitydir}' is perhaps not necessary, too.
Looks like you need to add requires for the following pakcages: numpy espeak Add those, and I am fine. I honestly am fine with the extra mkdir. Post the new requires and I will approve it. Thanks Bryan Here are the new files: Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-speak.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-speak-9-3.fc10.src.rpm APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. New Package CVS Request ======================= Package Name: sugar-speak Short Description: Speak for Sugar Owners: fab Branches: F-10 InitialCC: cvs done. sugar-speak-9-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sugar-speak-9-3.fc10 sugar-speak-9-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update sugar-speak'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11788 sugar-speak-9-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |