Bug 469952
| Summary: | Review Request: dopewars - a drug dealing game | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, gwync, notting |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-12 02:51:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Susi Lehtola
2008-11-04 21:13:16 UTC
New release fixes build in mock: http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars-1.5.12-2.src.rpm rpmlint output: dopewars.x86_64: E: zero-length /var/lib/games/dopewars.sco dopewars.x86_64: E: non-standard-executable-perm /usr/bin/dopewars 02755 dopewars-sdl.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 2 errors, 1 warnings. rpmlint: dopewars.i386: E: zero-length /var/lib/games/dopewars.sco Expected. dopewars.i386: E: non-standard-executable-perm /usr/bin/dopewars 02755 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. Acceptable. dopewars-sdl.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Probably fine. Other issues on full review: Source0: must include url: https://fedoraproject.org/wiki/Packaging/SourceURL Otherwise ok. (In reply to comment #2) > Source0: must include url: > https://fedoraproject.org/wiki/Packaging/SourceURL > > Otherwise ok. Good catch. http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars-1.5.12-3.src.rpm Looks good. APPROVED. New Package CVS Request ======================= Package Name: dopewars Short Description: A drug dealing game Owners: jussilehtola Branches: F-10 F-9 InitialCC: cvs done. dopewars-1.5.12-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/dopewars-1.5.12-4.fc9 dopewars-1.5.12-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/dopewars-1.5.12-4.fc10 dopewars-1.5.12-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. dopewars-1.5.12-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |