Bug 469952 - Review Request: dopewars - a drug dealing game
Summary: Review Request: dopewars - a drug dealing game
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-04 21:13 UTC by Susi Lehtola
Modified: 2008-11-22 16:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-11-12 02:51:53 UTC
Type: ---
Embargoed:
gwync: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Susi Lehtola 2008-11-04 21:13:16 UTC
Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars.spec

SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars-1.5.12-1.src.rpm

Description:

Based on John E. Dell's old Drug Wars game, dopewars is a simulation of an    
imaginary drug market.  dopewars is an All-American game which features       
buying, selling, and trying to get past the cops!                              
                                                                                
The first thing you need to do is pay off your debt to the Loan Shark. After   
that, your goal is to make as much money as possible (and stay alive)! You     
have one month of game time to make your fortune.                              

dopewars supports multiple players via. TCP/IP. Chatting to and fighting
with other players (computer or human) is supported; check the command line
switches (via dopewars -h) for further information.

Comment 1 Susi Lehtola 2008-11-04 21:27:05 UTC
New release fixes build in mock:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/dopewars-1.5.12-2.src.rpm

rpmlint output:
dopewars.x86_64: E: zero-length /var/lib/games/dopewars.sco
dopewars.x86_64: E: non-standard-executable-perm /usr/bin/dopewars 02755
dopewars-sdl.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 2 errors, 1 warnings.

Comment 2 Gwyn Ciesla 2008-11-06 19:50:20 UTC
rpmlint:

dopewars.i386: E: zero-length /var/lib/games/dopewars.sco

Expected.

dopewars.i386: E: non-standard-executable-perm /usr/bin/dopewars 02755
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

Acceptable.

dopewars-sdl.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Probably fine.

Other issues on full review:

Source0: must include url:
https://fedoraproject.org/wiki/Packaging/SourceURL

Otherwise ok.

Comment 4 Gwyn Ciesla 2008-11-07 18:22:22 UTC
Looks good.

APPROVED.

Comment 5 Susi Lehtola 2008-11-07 21:05:08 UTC
New Package CVS Request
=======================
Package Name: dopewars
Short Description: A drug dealing game
Owners: jussilehtola
Branches: F-10 F-9
InitialCC:

Comment 6 Kevin Fenzi 2008-11-07 21:28:39 UTC
cvs done.

Comment 7 Fedora Update System 2008-11-08 12:58:06 UTC
dopewars-1.5.12-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/dopewars-1.5.12-4.fc9

Comment 8 Fedora Update System 2008-11-08 12:59:00 UTC
dopewars-1.5.12-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/dopewars-1.5.12-4.fc10

Comment 9 Fedora Update System 2008-11-12 02:51:50 UTC
dopewars-1.5.12-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-11-22 16:59:52 UTC
dopewars-1.5.12-4.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.