Bug 470913
| Summary: | Review Request: lv2core - An Audio Plugin Standard | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Anthony Green <green> |
| Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bugs.michael, fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | bugs.michael:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-22 21:29:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 470914 | ||
|
Description
Anthony Green
2008-11-10 20:46:41 UTC
*** Bug 232465 has been marked as a duplicate of this bug. *** I note that this still includes a .pc file and is still arch-specific. I know the old ticket was closed but there are still open questions there and it would be really nice if you could address them. Comment #14 from Peter Jones, specifically. We should include the .pc file because packages depending on this package, like slv2, expect to find one (to test the version, I think) and there's no need to deviate from upstream.
I've added the
%define debug_package %{nil}
you suggested.
Spec URL: http://people.redhat.com/green/Fedora/lv2core.spec
SRPM URL: http://people.redhat.com/green/Fedora/lv2core-2.0-2.fc10.src.rpm
Thanks,
AG
In bug 232465 comment 2 I pointed out that the package is dual-licenced: API header is LGPLv2+, data file is MIT. => License: LGPLv2+ and MIT Authors's COPYING file says "BSD-style", but the licence text matches this: http://opensource.org/licenses/mit-license.php It is not clear to me why neither the LV2 bundledir ( %{_libdir}/lv2 ) nor the bundle name ( lv2core.lv2 ) are defined anywhere in the lv2.h file. That means applications would need to define it themselves. Hopefully they get it right and agree on a standard path. Home page lists a rev3 (2008-11-08) with a comment in the ChangeLog that says "unstable". Can't find any such classification of rev2. > %files > %doc AUTHORS COPYING README > %defattr(-,root,root,-) I suggest moving the %defattr one line up. Actually rpmlint reports this, too. > Summary: An Audio Plugin Standard I would drop the "An ". ;) Starting the %description with the following sentence from the home page would be an improvement: LV2 is a standard for plugins and matching host applications, mainly targeted at audio processing and generation. With those changes, which can be applied in pkg cvs, it's fine packaging-wise: APPROVED New Package CVS Request ======================= Package Name: lv2core Short Description: Audio Plugin Standard Owners: green Branches: F-10 InitialCC: cvs done. Closed - thanks! I believe that this package should be noarch and the .pc file should go to /usr/share/pkgconfig .
The files %{_datadir}/lv2 that are in the main package are actually devel files. They are templates to write lv2 plugins and are not needed during runtime. So only a devel package should be generated from the SRPM.
Also, I can't find the F-10 build.
Additionally, there is a new upstream version. I'm going to ask pkgdb access to fix these issues.
I opened a new bug to address the above issues. Ref: bug 490398 |