Bug 471809
| Summary: | Review Request: gnome-gmail-notifier - A simple application that monitors Gmail inboxes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Weller <ian> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-21 10:57:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ian Weller
2008-11-16 19:41:46 UTC
Need some work 1) remove vendor tag as per https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor I see some warnings also for desktop file but its ok. You can check those warnings in build log or output of desktop-file-validate 2) also you can remove original desktop file along with above fix as from rm %{buildroot}%{_datadir}/applications/%{name}.desktop desktop-file-install --vendor="fedora" --dir=%{buildroot}%{_datadir}/applications data/%{name}.desktop to desktop-file-install \ --delete-original \ --dir=%{buildroot}%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/%{name}.desktop 3) preserve timestamps by using make install as make install DESTDIR=%{buildroot} INSTALL="install -p" * Sun Nov 16 2008 Ian Weller <ianweller> 0.9.4-2 - Patch desktop file to correctly define the application's icon - Fix desktop file installation - Keep timestamps on installed files - Change URL to actual URL instead of Google Code project page Spec: http://ianweller.fedorapeople.org/SRPMS/gnome-gmail-notifier/0.9.4-2/gnome-gmail-notifier.spec SRPM: http://ianweller.fedorapeople.org/SRPMS/gnome-gmail-notifier/0.9.4-2/gnome-gmail-notifier-0.9.4-2.fc9.src.rpm Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=935765 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 822426b19510036d14c00ed2ea24a899 gnome-gmail-notifier-0.9.4.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file installed correctly. + GUI app. Suggestions:- Build is successful if you remove BR:gettext As currently no translations ar e present you can avoid adding this BR:gettext see http://koji.fedoraproject.org/koji/taskinfo?taskID=935770 without BR:gettext APPROVED. Thanks. New Package CVS Request ======================= Package Name: gnome-gmail-notifier Short Description: A simple application that monitors Gmail inboxes Owners: ianweller Branches: F-9 F-10 cvs done. gnome-gmail-notifier-0.9.4-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/gnome-gmail-notifier-0.9.4-3.fc9 gnome-gmail-notifier-0.9.4-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/gnome-gmail-notifier-0.9.4-3.fc10 gnome-gmail-notifier-0.9.4-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. gnome-gmail-notifier-0.9.4-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |