Bug 471873
Summary: | RFE: Nicer exit message when updateinfo is bad in repo. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Frank Ch. Eigler <fche> |
Component: | yum | Assignee: | Seth Vidal <skvidal> |
Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | urgent | Docs Contact: | |
Priority: | medium | ||
Version: | 9 | CC: | a.badger, ffesti, james.antill, katzj, lance, lmacken, pmatilai, tim.lauridsen |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-01-21 18:03:53 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Frank Ch. Eigler
2008-11-17 12:30:21 UTC
I have this bug reported against yumex too. https://bugzilla.redhat.com/show_bug.cgi?id=471731 File "/usr/lib/python2.5/site-packages/yum/update_md.py", line 70, in __init__ self._parse(elem) File "/usr/lib/python2.5/site-packages/yum/update_md.py", line 147, in _parse raise UpdateNoticeException("No id element found") yum.update_md.UpdateNoticeException: No id element found ...this isn't anything to do with yum-security ... the yum parser is failing. And this is the code: if child.tag == 'id': if not child.text: raise UpdateNoticeException("No id element found") ...so I'm tempted to say it's a rel-eng problem on whatever repo. is generating updates with an empty id. This was caused by a race condition in the push process. kernel-2.6.27.5-37.fc9 was obsoleted mid-push, after it was tagged with dist-f9-updates, but before it was able to assign an update ID. Therefore, this update was injected into the updateinfo with an empty id tag. I have since fixed the update, and fresh repositories are mashing as we speak. I filed a ticket against bodhi to fix this race condition: https://fedorahosted.org/bodhi/ticket/265 (In reply to comment #2) > ...this isn't anything to do with yum-security ... the yum parser is failing. > And this is the code: > [...] > ...so I'm tempted to say it's a rel-eng problem on whatever repo. is generating > updates with an empty id. IMO it is unacceptable for the software to fail this way merely because of some network data problem. Let it skip the troubling xml and emit a warning, with a well-placed try: / except:. I disagree ... failing silently (by skipping the repodata) is a bad idea suddently yum --security will silently not update security errata (because the data is bad so it skips everything). I guess we could catch it at the top level of yum, so there is no backtrace, but I also wouldn't classify this as a normal failure condition. The fixed repos should have hit our mirrors a couple of days ago. all in all it is fixed. As we make adjustments to the security pluging and update_md in general we'll make it better. |