Bug 473054

Summary: faillog -p takes forever if /var/log/faillog has gone huge sparse.
Product: Red Hat Enterprise Linux 5 Reporter: Martin Poole <mpoole>
Component: shadow-utilsAssignee: Peter Vrabec <pvrabec>
Status: CLOSED ERRATA QA Contact: BaseOS QE <qe-baseos-auto>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.2CC: lkukline, mmalik, mpoole, ofourdan, sgrubb, tao, tmraz
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-30 08:13:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch against shadow-utils-4.0.17-14.el5 none

Description Martin Poole 2008-11-26 10:30:04 UTC
+++ This bug was initially created as a clone of Bug #469702 +++

Escalated to Bugzilla from IssueTracker

--- Additional comment from mpoole on 2008-11-03 11:13:31 EDT ---

There is a bug with the print code in that is simply reads the whole file sequentially to meet the man page of printing in UID order. Since the output does not actually include the UID it is a little redundant stating or assuming UID order which therefore gives an optimal way of reworking the code.

--- Additional comment from mpoole on 2008-11-03 11:15:23 EDT ---

Created an attachment (id=322334)
patch reworking entry read/writes and avoid filling in holes. also optimal print

Comment 1 RHEL Program Management 2009-03-26 17:13:30 UTC
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".

Comment 2 Lukas Kuklinek 2009-04-06 07:42:39 UTC
Created attachment 338295 [details]
patch against shadow-utils-4.0.17-14.el5

The patch has been reworked so that it can be applied to shadow-utils-4.0.17-14.el5. Have a look at it, some of the issues were implemented a bit differently...

Comment 3 Martin Poole 2009-10-22 10:54:15 UTC
Flagging for fast.

Comment 4 Peter Vrabec 2009-11-02 12:33:28 UTC
*** Bug 517816 has been marked as a duplicate of this bug. ***

Comment 6 Martin Poole 2009-11-05 09:44:19 UTC
Reproducer best performed on x86_64.


# ls -l /var/log/faillog
-rw------- 1 root root 2784 Aug 27 21:37 /var/log/faillog
# faillog -m 5
# ls -l /var/log/faillog
-rw------- 1 root root 137438953440 Sep 25 13:22 /var/log/faillog
# faillog -p

command should return some time before next millenium,

Comment 10 errata-xmlrpc 2010-03-30 08:13:29 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0209.html