Bug 473585

Summary: jetty : Unowned directories
Product: [Fedora] Fedora Reporter: Michael Schwendt <bugs.michael>
Component: jettyAssignee: Jeff Johnston <jjohnstn>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: jjohnstn, overholt
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 5.1.15-3.fc10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-25 12:35:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Schwendt 2008-11-29 15:40:31 UTC
One or more directories are not included within this
package and/or its sub-packages:

=> jetty-5.1.14-1.6.fc10.i386 (rawhide-development-i386)
/var/cache/jetty
/var/lib/jetty
/usr/share/doc/jetty-5.1.14

=> jetty-javadoc-5.1.14-1.6.fc10.i386 (rawhide-development-i386)
/var/lib/jetty
/var/lib/jetty/webapps

[...]

Further information:

https://fedoraproject.org/wiki/Packaging/ReviewGuidelines

MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory.

https://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership
https://fedoraproject.org/wiki/Packaging/UnownedDirectories

Comment 1 Fedora Update System 2009-01-06 21:55:37 UTC
jetty-5.1.14-1.7.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/jetty-5.1.14-1.7.fc10

Comment 2 Fedora Update System 2009-01-07 21:51:53 UTC
jetty-5.1.14-1.7.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update jetty'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0294

Comment 3 Michael Schwendt 2009-02-01 14:38:10 UTC
This ticket is about Rawhide, not Fedora 10!

In Rawhide there are still unowned directories, some of them due to incomplete inter-package dependencies:

=> jetty-5.1.14-1.7.fc11.src.rpm
=> jetty-5.1.14-1.7.fc11.i386 (rawhide)
/var/cache/jetty
/var/lib/jetty
/usr/share/doc/jetty-5.1.14
    provided by: jetty-manual-5.1.14-1.7.fc11.i386
/etc/init.d
    provided by: chkconfig-1.3.41-1.i386

=> jetty-5.1.14-1.7.fc11.src.rpm
=> jetty-javadoc-5.1.14-1.7.fc11.i386 (rawhide)
/var/lib/jetty
/var/lib/jetty/webapps
    provided by: jetty-5.1.14-1.7.fc11.i386

Comment 4 Jeff Johnston 2009-02-02 20:25:41 UTC
(In reply to comment #3)
> This ticket is about Rawhide, not Fedora 10!
> 
> In Rawhide there are still unowned directories, some of them due to incomplete
> inter-package dependencies:
> 
> => jetty-5.1.14-1.7.fc11.src.rpm
> => jetty-5.1.14-1.7.fc11.i386 (rawhide)
> /var/cache/jetty
> /var/lib/jetty
> /usr/share/doc/jetty-5.1.14
>     provided by: jetty-manual-5.1.14-1.7.fc11.i386
> /etc/init.d
>     provided by: chkconfig-1.3.41-1.i386
> 
> => jetty-5.1.14-1.7.fc11.src.rpm
> => jetty-javadoc-5.1.14-1.7.fc11.i386 (rawhide)
> /var/lib/jetty
> /var/lib/jetty/webapps
>     provided by: jetty-5.1.14-1.7.fc11.i386

I have rebuilt a 1.8 version after finding a script that tests for unowned directories and files.  The 1.8 rpm passes on my F-10 system after being installed.  The rawhide rpm was also built using the same spec file.

I am not sure why you are flagging chkconfig above since it is in the Requires for the main package.  FWIW: I made the javadoc and manual subpackages require the main package and I made the main package own /var/cache/jetty /var/lib/jetty and /usr/share/doc/jetty-5.1.14.

Comment 5 Michael Schwendt 2009-02-03 10:07:57 UTC
chkconfig is in the results, because you use /etc/init.d instead of %{_initrddir}:

  $ rpm --eval %{_initrddir}
  /etc/rc.d/init.d

/etc/init.d is not a directory, it's just a symlink to a directory. So far, the "provided by" lines are only hints, to show whether any other pkg in the repos provides a path. In some cases, this reveals conflicts between a file/symlink and a directory.

Comment 6 Fedora Update System 2009-02-05 02:14:11 UTC
jetty-5.1.14-1.8.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update jetty'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1280

Comment 7 Jeff Johnston 2009-02-06 20:13:33 UTC
(In reply to comment #5)
> chkconfig is in the results, because you use /etc/init.d instead of
> %{_initrddir}:
> 
>   $ rpm --eval %{_initrddir}
>   /etc/rc.d/init.d
> 
> /etc/init.d is not a directory, it's just a symlink to a directory. So far, the
> "provided by" lines are only hints, to show whether any other pkg in the repos
> provides a path. In some cases, this reveals conflicts between a file/symlink
> and a directory.

Ok, I have just pushed a new rpm that contains this fix as well.

Comment 8 Fedora Update System 2009-02-07 22:21:48 UTC
jetty-5.1.14-1.9.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update jetty'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1469

Comment 9 Michael Schwendt 2009-04-01 13:12:13 UTC
In the package files list a new unowned dir is found:

=> jetty-5.1.14-2.10.fc11.src.rpm
=> jetty-5.1.14-2.10.fc11.i586 (rawhide)
/var/lib/jetty/lib

[...]

The script to find unowned directories is not complete yet, but
still quite usable: http://mschwendt.fedorapeople.org/dircheck-remote.py
$ ./dircheck-remote.py -r rawhide -n ^jetty

Comment 10 Jeff Johnston 2009-04-07 21:06:45 UTC
(In reply to comment #9)
> In the package files list a new unowned dir is found:
> 
> => jetty-5.1.14-2.10.fc11.src.rpm
> => jetty-5.1.14-2.10.fc11.i586 (rawhide)
> /var/lib/jetty/lib
> 
> [...]
> 
> The script to find unowned directories is not complete yet, but
> still quite usable: http://mschwendt.fedorapeople.org/dircheck-remote.py
> $ ./dircheck-remote.py -r rawhide -n ^jetty  

Is there a way to use this script on a local rpm build (i.e. to make sure it is ok before pushing it to rawhide)?

Comment 11 Michael Schwendt 2009-04-08 07:44:14 UTC
It accepts an arbitrary number of -r arguments which you can use to point it to a local repository in addition to rawhide.

Comment 12 Fedora Update System 2009-04-23 16:13:14 UTC
jetty-5.1.14-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/jetty-5.1.14-3.fc10

Comment 13 Fedora Update System 2009-05-22 19:29:01 UTC
jetty-5.1.15-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/jetty-5.1.15-3.fc10

Comment 14 Fedora Update System 2009-05-26 07:57:00 UTC
jetty-5.1.15-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.