Bug 474012 (qodem)
Summary: | Review Request: qodem - terminal emulator and communications package. | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeff Gustafson <ncjeffgus> | ||||
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | CC: | fedora-package-review, hobbes1069, notting, tomspur | ||||
Target Milestone: | --- | Keywords: | Reopened | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://qodem.sourceforge.net/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2011-07-24 22:32:09 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Jeff Gustafson
2008-12-01 19:25:02 UTC
Is there anything else I need to do to this package/spec to spur further consideration on this package? At the first glance, I'd say that the license should be GPLv2+ because all the source files include either This program is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. or (note the "later" in the last line ) * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. The combination LGPLv2+ + GPLv2+ = GPLv2+ You should also drop the Requires line, rpmbuild will add the dependency automatically. The INSTALL file is useless for the users of the packaged qodem so I suggest to not include it at all. OTOH, you should include the manpage available as docs/qodem.1.The content of the NEWS file makes reference to a [much] older version, I would not include it (no problem however if you keep it, but the elegant procedure would be to remove it now and reinclude it if/when real news are provided). For language files there is a special procedure, please read and follow https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files. Please make sure you do not build your package against the bundled gettext (it is included below the intl/ directory). You should BuildRequire gettext instead. Created attachment 327029 [details]
Patch Makefile so that it ignores the included gettext directory
Thank you for checking out the package. I made the suggested changes. I make some quick changes to force the build to use the system-wide gettext. Let me know if this is either too heavy-handed or not going far enough. I included the patch as an attachment to this bug entry. I updated the .spec file and copied it up to the location initially reported in this entry. One other option would be to use the English-only .tar.gz file for qodem and avoid the gettext issue entirely. That way no .patch file would be needed. Jeff, is there an updated package available for review ? At http://marlene.zimage.com/packages/ I can only see the first src.rpm Please do not forget to increment the release tag and add a proper entry in the changelog each time you make modifications to the spec. Are you already sponsored? I have not found you in FAS. It's been many months since the last comment with no response from the submitter; I'll close this ticket soon if there's no progress. Somehow I must have missed your message. I made the requested changes. If there is issues with gettext, I will just compile with the English only version. Sorry, where did you make the requested changes? Could you post links to the updated spec and src.rpm? (In reply to comment #5) > Are you already sponsored? I have not found you in FAS. I didn't found you, too and can't find an answer to the question in a comment above. Asking again: Are you already sponsored? (In reply to comment #6) > It's been many months since the last comment with no response from the > submitter; I'll close this ticket soon if there's no progress. There seems to be progress, but no release incremention... Your changelog from above is: %changelog * Sun Nov 30 2008 Jeff Gustafson <jeffgus at, fedoraproject.org> - 0.1.2-1 - Initial package creation After applying the patch you could write: %changelog * Sun Oct 4 2009 Jeff Gustafson <jeffgus at, fedoraproject.org> - 0.1.2-2 - patch for gettext * Sun Nov 30 2008 Jeff Gustafson <jeffgus at, fedoraproject.org> - 0.1.2-1 - Initial package creation Notice the version incremention from 0.1.2-1 to 0.1.2-2. And post *new* links to the uploaded spec and src.rpm... (In reply to comment #6) > It's been many months since the last comment with no response from the > submitter; I'll close this ticket soon if there's no progress. Some month later, "soon" starts again from now on :) There's been no response in many months; I'm just going to go ahead and close this. I recently did some retro-BBS'ing and found qodem. I've created a package that I think should be acceptable. SPEC: http://hobbes1069.fedorapeople.org/qodem/qodem.spec SRPM: http://hobbes1069.fedorapeople.org/qodem/qodem-0.3.2-1.fc14.src.rpm I'm not going to consider this bug "ASSIGNED" anymore.... You should open your own review request and close this one as a duplicate of the new one. Then reporter is equal to review requester... *** This bug has been marked as a duplicate of bug 725267 *** |