Bug 474053
| Summary: | Add -DCMAKE_VERBOSE_MAKEFILE=ON to %cmake | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | cmake | Assignee: | Rex Dieter <rdieter> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | jreznik, kevin, opensource, orion, pertusus, rdieter, than | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-12-02 17:58:58 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
(In reply to comment #0) > I don't know why we'd want non-verbose Makefiles for rpm package builds, but if > someone comes up with a reason, verbosity could be turned off with "%cmake > -DCMAKE_VERBOSE_MAKEFILE=OFF". ...that on per-package basis in specfiles, that is. I strongly agree that this should be made default, especially because the cmake guidelines[1] already tell to use "VERBOSE=1", which has probably the same effect. [1] https://fedoraproject.org/wiki/Packaging/cmake totally +1. Orion, any comment/objection? Sounds great to me (I use VERBOSE=1 myself everywhere). Ville - can you push this through? I'm very busy at the moment. I'll take care of it. fixed in rawhide. We can let it stew awhile, and consider issuing updates for releases soonish. Thanks, Rex. Do you plan to do this also to macros.kde4 in kde-filesystem? Looks like it's not there in CVS yet. yep. cmake-2.6.2-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/cmake-2.6.2-3.fc9 cmake-2.6.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/cmake-2.6.2-3.fc10 cmake-2.6.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. cmake-2.6.2-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 325298 [details] Use verbose makefiles by default I think the default %cmake macro should contain -DCMAKE_VERBOSE_MAKEFILE=ON. "Silent" Makefiles cause problems with verifying that a build process does what we want which makes reviews harder (or the other way around, easier to miss things in package reviews). For example desired C*FLAGS in effect, desired arguments to "install" etc. I don't know why we'd want non-verbose Makefiles for rpm package builds, but if someone comes up with a reason, verbosity could be turned off with "%cmake -DCMAKE_VERBOSE_MAKEFILE=OFF". (Cc'ing kde-filesystem maintainers - macros.kde4 has the same "problem".)