Bug 474053 - Add -DCMAKE_VERBOSE_MAKEFILE=ON to %cmake
Summary: Add -DCMAKE_VERBOSE_MAKEFILE=ON to %cmake
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: cmake
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-01 21:12 UTC by Ville Skyttä
Modified: 2009-01-21 21:37 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-12-02 17:58:58 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Use verbose makefiles by default (626 bytes, patch)
2008-12-01 21:12 UTC, Ville Skyttä 		no flags Details | Diff
View All

Description Ville Skyttä 2008-12-01 21:12:46 UTC 
Created attachment 325298 [details]
Use verbose makefiles by default

I think the default %cmake macro should contain -DCMAKE_VERBOSE_MAKEFILE=ON.

"Silent" Makefiles cause problems with verifying that a build process does what we want which makes reviews harder (or the other way around, easier to miss things in package reviews).  For example desired C*FLAGS in effect, desired arguments to "install" etc.

I don't know why we'd want non-verbose Makefiles for rpm package builds, but if someone comes up with a reason, verbosity could be turned off with "%cmake -DCMAKE_VERBOSE_MAKEFILE=OFF".

(Cc'ing kde-filesystem maintainers - macros.kde4 has the same "problem".)
Comment 1 Ville Skyttä 2008-12-01 21:13:27 UTC 
(In reply to comment #0)
> I don't know why we'd want non-verbose Makefiles for rpm package builds, but if
> someone comes up with a reason, verbosity could be turned off with "%cmake
> -DCMAKE_VERBOSE_MAKEFILE=OFF".

...that on per-package basis in specfiles, that is.
Comment 2 Till Maas 2008-12-01 21:25:57 UTC 
I strongly agree that this should be made default, especially because the cmake guidelines[1] already tell to use "VERBOSE=1", which has probably the same effect. 

[1] https://fedoraproject.org/wiki/Packaging/cmake
Comment 3 Rex Dieter 2008-12-01 22:02:35 UTC 
totally +1.

Orion, any comment/objection?
Comment 4 Orion Poplawski 2008-12-02 17:15:33 UTC 
Sounds great to me (I use VERBOSE=1 myself everywhere).  Ville - can you push this through?  I'm very busy at the moment.
Comment 5 Rex Dieter 2008-12-02 17:29:27 UTC 
I'll take care of it.
Comment 6 Rex Dieter 2008-12-02 17:58:58 UTC 
fixed in rawhide.

We can let it stew awhile, and consider issuing updates for releases soonish.
Comment 7 Ville Skyttä 2008-12-02 19:02:04 UTC 
Thanks, Rex.  Do you plan to do this also to macros.kde4 in kde-filesystem?  Looks like it's not there in CVS yet.
Comment 8 Rex Dieter 2008-12-02 19:08:18 UTC 
yep.
Comment 9 Fedora Update System 2009-01-15 20:55:23 UTC 
cmake-2.6.2-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/cmake-2.6.2-3.fc9
Comment 10 Fedora Update System 2009-01-15 20:56:13 UTC 
cmake-2.6.2-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/cmake-2.6.2-3.fc10
Comment 11 Fedora Update System 2009-01-16 23:41:31 UTC 
cmake-2.6.2-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2009-01-21 21:37:03 UTC 
cmake-2.6.2-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.