Bug 474864 (perl-Test-Signature)
| Summary: | Review Request: perl-Test-Signature - Automated SIGNATURE testing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, perl-devel |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-09 06:05:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Iain Arnell
2008-12-05 17:00:27 UTC
Your manual dependency on Test::Builder results in a duplicated dependency in the final package; rpm -qp --requires perl-Test-Signature-1.10-1.fc11.noarch.rpm yields:
perl(Test::Builder)
perl(Test::Builder) >= 0.17
which is pointless. Admittedly rpm should not do this, but in the meantime it is worth asking if you really need the manual versioned dependency. Even F8, which is going EOL soon, shipped with Test::Builder 0.32.
* source files match upstream. sha256sum:
08375ba37c26d3c062e4d54bf0042b51ab20f4f7ef5b9e5cb23cc0829d2befd5
Test-Signature-1.10.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
X final provides and requires:
perl(Test::Signature) = 1.10
perl-Test-Signature = 1.10-1.fc11
=
perl >= 0:5.004
perl(:MODULE_COMPAT_5.10.0)
perl(Exporter)
X perl(Test::Builder)
X perl(Test::Builder) >= 0.17
perl(Test::More) >= 0.47
perl(strict)
perl(vars)
* %check is present and all tests pass:
All tests successful.
Files=2, Tests=2, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.01 cusr 0.00
csys = 0.03 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Ok. And the Test::More requirement was wrong too (automatically picked up by cpanspec from pod, I guess). New SRPM: http://iarnell.fedorapeople.org/perl-Test-Signature-1.10-2.fc11.src.rpm New spec: http://iarnell.fedorapeople.org/perl-Test-Signature.spec Mental note - don't think before drinking coffee. Of course, cpanspec picked up the Test::More requirement from META.YML or Makefile.PL - nothing sinister with pod. Thanks; the dependencies look good now. APPROVED New Package CVS Request ======================= Package Name: perl-Test-Signature Short Description: Automated SIGNATURE testing Owners: iarnell Branches: F-9 F-10 InitialCC: perl-sig cvs done. perl-Test-Signature-1.10-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Test-Signature-1.10-2.fc10 perl-Test-Signature-1.10-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Test-Signature-1.10-2.fc9 perl-Test-Signature-1.10-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-Signature-1.10-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: perl-Test-Signature New Branches: EL-5 Owners: iarnell InitialCC: perl-sig cvs done. |