Bug 474864 (perl-Test-Signature) - Review Request: perl-Test-Signature - Automated SIGNATURE testing
Summary: Review Request: perl-Test-Signature - Automated SIGNATURE testing
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Test-Signature
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-05 17:00 UTC by Iain Arnell
Modified: 2009-01-29 00:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-09 06:05:07 UTC
Type: ---
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2008-12-05 17:00:27 UTC
Spec URL: http://iarnell.fedorapeople.org/perl-Test-Signature.spec
SRPM URL: http://iarnell.fedorapeople.org/perl-Test-Signature-1.10-1.fc11.src.rpm
Description: 
Module::Signature allows you to verify that a distribution has not been
tampered with. Test::Signature lets that be tested as part of the
distribution's test suite.

Comment 1 Jason Tibbitts 2008-12-06 23:14:14 UTC
Your manual dependency on Test::Builder results in a duplicated dependency in the final package; rpm -qp --requires perl-Test-Signature-1.10-1.fc11.noarch.rpm yields:
  perl(Test::Builder)
  perl(Test::Builder) >= 0.17

which is pointless.  Admittedly rpm should not do this, but in the meantime it is worth asking if you really need the manual versioned dependency.  Even F8, which is going EOL soon, shipped with Test::Builder 0.32.

* source files match upstream.  sha256sum:
   08375ba37c26d3c062e4d54bf0042b51ab20f4f7ef5b9e5cb23cc0829d2befd5  
   Test-Signature-1.10.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
X final provides and requires:
   perl(Test::Signature) = 1.10
   perl-Test-Signature = 1.10-1.fc11
  =
   perl >= 0:5.004
   perl(:MODULE_COMPAT_5.10.0)
   perl(Exporter)
X  perl(Test::Builder)
X  perl(Test::Builder) >= 0.17
   perl(Test::More) >= 0.47
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=2,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.01 cusr  0.00 
    csys =  0.03 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Comment 2 Iain Arnell 2008-12-07 08:53:24 UTC
Ok.  And the Test::More requirement was wrong too (automatically picked up by cpanspec from pod, I guess).

New SRPM: http://iarnell.fedorapeople.org/perl-Test-Signature-1.10-2.fc11.src.rpm
New spec: http://iarnell.fedorapeople.org/perl-Test-Signature.spec

Comment 3 Iain Arnell 2008-12-07 09:58:44 UTC
Mental note - don't think before drinking coffee.  Of course, cpanspec picked up the Test::More requirement from META.YML or Makefile.PL - nothing sinister with pod.

Comment 4 Jason Tibbitts 2008-12-07 18:29:51 UTC
Thanks; the dependencies look good now.

APPROVED

Comment 5 Iain Arnell 2008-12-07 21:12:31 UTC
New Package CVS Request
=======================
Package Name: perl-Test-Signature
Short Description: Automated SIGNATURE testing
Owners: iarnell
Branches: F-9 F-10
InitialCC: perl-sig

Comment 6 Kevin Fenzi 2008-12-08 00:31:58 UTC
cvs done.

Comment 7 Fedora Update System 2008-12-08 05:39:38 UTC
perl-Test-Signature-1.10-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Test-Signature-1.10-2.fc10

Comment 8 Fedora Update System 2008-12-08 05:39:41 UTC
perl-Test-Signature-1.10-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/perl-Test-Signature-1.10-2.fc9

Comment 9 Fedora Update System 2008-12-18 00:33:27 UTC
perl-Test-Signature-1.10-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-12-18 00:40:44 UTC
perl-Test-Signature-1.10-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Iain Arnell 2009-01-28 16:37:37 UTC
Package Change Request
======================
Package Name: perl-Test-Signature
New Branches: EL-5
Owners: iarnell
InitialCC: perl-sig

Comment 12 Kevin Fenzi 2009-01-29 00:28:41 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.