Bug 474867 (perl-B-Utils)
| Summary: | Review Request: perl-B-Utils - Helper functions for op tree manipulation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, ianburrell, notting, perl-devel |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-19 07:50:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 474859 | ||
|
Description
Iain Arnell
2008-12-05 17:09:14 UTC
Not much to say here. I agree that the rpmlint complaint is OK, as occasionally a single internal header file comes as part of a binary Perl module.
One of the tests is skipped due to a lack of Test::Signature, but honestly verifying signatures as part of the test suite isn't useful in all cases. If we need to patch a file, for example, the tests would fail.
* source files match upstream. sha256sum:
b2609a722def7499952831f4a72fd0bf6786e64414bd74607cd89637bbb2d59a
B-Utils-0.07.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
Utils.so()(64bit)
perl(B::Utils) = 0.07
perl(B::Utils::Install::Files)
perl(B::Utils::OP) = 0.07
perl-B-Utils = 0.07-1.fc11
perl-B-Utils(x86-64) = 0.07-1.fc11
=
perl >= 0:5.006
perl(:MODULE_COMPAT_5.10.0)
perl(B)
perl(B::Utils)
perl(Carp)
perl(Exporter)
perl(Scalar::Util)
perl(base)
perl(strict)
perl(subs)
perl(vars)
perl(warnings)
* %check is present and all tests pass:
All tests successful.
Files=22, Tests=136, 1 wallclock secs ( 0.06 usr 0.03 sys + 0.54 cusr
0.08 csys = 0.71 CPU)
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
New Package CVS Request ======================= Package Name: perl-B-Utils Short Description: Helper functions for op tree manipulation Owners: iarnell Branches: F-9 F-10 InitialCC: perl-sig cvs done. perl-B-Utils-0.07-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-B-Utils-0.07-2.fc10 perl-B-Utils-0.07-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-B-Utils-0.07-2.fc9 perl-B-Utils-0.07-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. perl-B-Utils-0.07-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: perl-B-Utils New Branches: EL-5 Owners: iarnell iburrell InitialCC: perl-sig cvs done. |