Bug 474910
| Summary: | Review Request: esperanza - A graphical audio player | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.4.0-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-09 22:49:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 474908 | ||
| Bug Blocks: | |||
|
Description
Tom "spot" Callaway
2008-12-05 21:22:55 UTC
Let's make xmms2 a little more useful. Here's my notes:
- rpmlint says:
esperanza.src:28: W: configure-without-libdir-spec
but I guess this can be safely ignored.
* There are binary translation files (.qm) in the tarball which need to be removed and rebuilt (via lrelease).
? Where are these translations going? Are they getting compiled into the final binary?
? I think the files data/text/*.html need to go to %doc (if they are not getting compiled into the binary but I couldn't find them within the application)
* Fedora specific flag "-fexceptions" is not passed to the compiler. The other flags are ok.
I think the translations are going into qrc_esperanza.cpp which is compiled into libdata.a, which gets shoved into esperanza. The missing -fexception flags is because QT is not built with that flag: # drop -fexceptions from $RPM_OPT_FLAGS RPM_OPT_FLAGS=`echo $RPM_OPT_FLAGS | sed 's|-fexceptions||g'` (from devel/qt.spec) All of the optflags seem to be generated on the fly from qmake, and I'm honestly not sure how to override them to add this one back in... With the exception of that, everything else is fixed here: New SRPM: http://www.auroralinux.org/people/spot/review/new/esperanza-0.4.0-2.fc11.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/esperanza.spec OK. I believe everything is as good as it can be now. -------------------------------------------- This package (esperanza) is APPROVED by oget -------------------------------------------- New Package CVS Request ======================= Package Name: esperanza Short Description: A graphical audio player Owners: spot Branches: F-9 F-10 devel InitialCC: ... and it's done. esperanza-0.4.0-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/esperanza-0.4.0-2.fc9 esperanza-0.4.0-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/esperanza-0.4.0-2.fc10 esperanza-0.4.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. esperanza-0.4.0-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |