Red Hat Bugzilla – Bug 474910
Review Request: esperanza - A graphical audio player
Last modified: 2009-03-09 18:57:01 EDT
Spec URL: http://www.auroralinux.org/people/spot/review/new/esperanza.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/esperanza-0.4.0-1.fc11.src.rpm
Esperanza is an audio player for the XMMS2 framework written with C++ and QT4.
It has a sleek, uncomplicated UI, and supports album art in the playlist.
Let's make xmms2 a little more useful. Here's my notes:
- rpmlint says:
esperanza.src:28: W: configure-without-libdir-spec
but I guess this can be safely ignored.
* There are binary translation files (.qm) in the tarball which need to be removed and rebuilt (via lrelease).
? Where are these translations going? Are they getting compiled into the final binary?
? I think the files data/text/*.html need to go to %doc (if they are not getting compiled into the binary but I couldn't find them within the application)
* Fedora specific flag "-fexceptions" is not passed to the compiler. The other flags are ok.
I think the translations are going into qrc_esperanza.cpp which is compiled into libdata.a, which gets shoved into esperanza.
The missing -fexception flags is because QT is not built with that flag:
# drop -fexceptions from $RPM_OPT_FLAGS
RPM_OPT_FLAGS=`echo $RPM_OPT_FLAGS | sed 's|-fexceptions||g'`
All of the optflags seem to be generated on the fly from qmake, and I'm honestly not sure how to override them to add this one back in...
With the exception of that, everything else is fixed here:
New SRPM: http://www.auroralinux.org/people/spot/review/new/esperanza-0.4.0-2.fc11.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/esperanza.spec
OK. I believe everything is as good as it can be now.
This package (esperanza) is APPROVED by oget
New Package CVS Request
Package Name: esperanza
Short Description: A graphical audio player
Branches: F-9 F-10 devel
... and it's done.
esperanza-0.4.0-2.fc9 has been submitted as an update for Fedora 9.
esperanza-0.4.0-2.fc10 has been submitted as an update for Fedora 10.
esperanza-0.4.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
esperanza-0.4.0-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.