Bug 474983

Successfully created a mock-(re)build of this version of this pkg.

(Removing NEEDSPONSOR)

Spec URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI-1.3-1.fc10.src.rpm

New version including much of the experience I got when my jcalendar pkg was
reviewed.

Spec URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI-1.3-1.fc11.src.rpm

Rebuilt on rawhide.

Well, 

Many files under xml/ directory has the statement:
---------------------------------------------------------------
Use of this BBC data for non-TV-Anytime purposes is strictly forbidden
---------------------------------------------------------------

I guess this statement renders this software non-free.
spot, how do you think?

At the very least, the xml data is non-free and not permissable in Fedora.

Spec URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI-1.3-2.fc11.src.rpm

- Removed the xml/ subdir for legal problems.
- Also removed lib/* and docs/ because I was already modifying the source archive anyway.
- Added examples/ to the docs

Removing FE-Legal. Thank you, spot.

For 1.3-2:

* License
  - The License tag should be "LGPLv2+".

* javadoc directory
  - Would you explain why you don't simply use
    %{_javadocdir}/%{name} as javadoc installation
    directory and instead want to use %_javadocdir/%name-%version
    and create symlink?

    ! Note
      On rpm packaging please take much care of creating symlink
      pointing to directory, because with rpm restriction (or cpio?)
      once this is done it gets very difficult to change this
      symlink to actual directory or so.

Spec URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI-1.3-2.fc11.src.rpm


* License corrected.

* Because I was told I should in another review: https://bugzilla.redhat.com/show_bug.cgi?id=475019#c6
...honestly, I've also just checked my /usr/share/javadoc/* and while there's not much in there, everything is using %name-%version with a symlink to it :)

Well, where is your new srpm? (please change the release number
every time you modify your spec file)

Spec URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/TVAnytimeAPI-1.3-3.fc11.src.rpm

(In reply to comment #10)
> * Because I was told I should in another review:
> https://bugzilla.redhat.com/show_bug.cgi?id=475019#c6
> ...honestly, I've also just checked my /usr/share/javadoc/* and while there's
> not much in there, everything is using %name-%version with a symlink to it :)

I checked this by using repoquery, i.e. _all_ packages installing
javadoc files under /usr/share/javadoc/. 

It seems packages reviewed in earlier days seem to be creating such symlinks.
Actually this is the first package creating javadoc subpackage trying
to create such symlink I reviewed. However this is not a blocker.

-------------------------------------------------------
   This package (TVAnytimeAPI) is APPROVED by mtasaka
-------------------------------------------------------

New Package CVS Request
=======================
Package Name: TVAnytimeAPI
Short Description: A Java API for parsing, manipulating and creating TV-Anytime metadata
Owners: red
Branches: F-9 F-10
InitialCC:

cvs done.

Please rebuild this package on koji and for F-10/9
submit requests to push the rebuilt packages into repositories.

Now closing, thank you.

TVAnytimeAPI-1.3-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

TVAnytimeAPI-1.3-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.