Bug 475019 - Review Request: opencsv - A very simple csv (comma-separated values) parser library for Java
Summary: Review Request: opencsv - A very simple csv (comma-separated values) parser l...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: tvbrowser
TreeView+ depends on / blocked
 
Reported: 2008-12-06 19:08 UTC by Sandro Mathys
Modified: 2009-01-29 23:09 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-29 23:08:07 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Sandro Mathys 2008-12-06 19:08:47 UTC
Spec URL: http://red.fedorapeople.org/SRPMS/opencsv.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/opencsv-1.8-0.1.fc10.src.rpm
Description: Support for all the basic csv-type things you're likely to want to do:
* Arbitrary numbers of values per line
* Ignoring commas in quoted elements
* Handling quoted entries with embedded carriage returns
  (i.e. entries that span multiple lines)
* Configurable separator and quote characters (or use sensible defaults)
* Read all the entries at once, or use an Iterator style model
* Creating csv files from String[]
  (i.e. automatic escaping of embedded quote chars)

This  is a dependency needed for tvbrowser, for which a review request exists
already.

rpmlint on spec, srpm and noarch-rpms finishes checking without any warnings or
errors - except for a "W: no-documentation" because there's no license text in the source.

I'd still need a sponsor.

Comment 1 Sandro Mathys 2008-12-12 01:01:29 UTC
Successfully created a mock-(re)build of this version of this pkg.

Comment 2 Mamoru TASAKA 2008-12-15 15:00:15 UTC
(Removing NEEDSPONSOR)

Comment 3 Sandro Mathys 2008-12-16 04:31:19 UTC
Spec URL: http://red.fedorapeople.org/SRPMS/opencsv.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/opencsv-1.8-1.fc10.src.rpm

New version including much of the experience I got when my jcalendar pkg was
reviewed.

Comment 4 Sandro Mathys 2008-12-18 22:00:00 UTC
Spec URL: http://red.fedorapeople.org/SRPMS/opencsv.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/opencsv-1.8-1.fc10.src.rpm

Rebuilt on rawhide.

Comment 5 Thomas Moschny 2008-12-19 18:11:57 UTC
(In reply to comment #4)
> Spec URL: http://red.fedorapeople.org/SRPMS/opencsv.spec
> SRPM URL: http://red.fedorapeople.org/SRPMS/opencsv-1.8-1.fc10.src.rpm

The src.rpm doesn't exist - I guess you mean:
http://red.fedorapeople.org/SRPMS/opencsv-1.8-1.fc11.src.rpm

Comment 6 Thomas Moschny 2008-12-19 18:34:00 UTC
Some remarks:

- Source0 should read http://downloads.sourceforge.net/%{name}/%{name}-%{version}-src-with-libs.tar.gz.

- there's no 'build' directory to be removed.

- you could move the 'example' sources to %doc.

- in %{_javadocdir} move the docs to %{name}-%{version} and make a symlink %{name} pointing to that dir.

- feature lists in the %description are considered deprecated by some people.

Comment 7 Sandro Mathys 2009-01-09 22:31:20 UTC
Spec URL: http://red.fedorapeople.org/SRPMS/opencsv.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/opencsv-1.8-1.fc11.src.rpm

Everything has been addressed.

Comment 8 Mamoru TASAKA 2009-01-17 16:57:43 UTC
Please change the release number every time you change
your spec file

(In reply to comment #6)
> - in %{_javadocdir} move the docs to %{name}-%{version} and make a symlink
> %{name} pointing to that dir.

This is not needed.

Comment 9 Mamoru TASAKA 2009-01-19 15:42:02 UTC
(What I mean is that the latest srpm does not seem to have addressed
 the issue raised on the comment 6)

Comment 10 Sandro Mathys 2009-01-26 23:05:21 UTC
Spec URL: http://red.fedorapeople.org/SRPMS/opencsv.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/opencsv-1.8-2.fc11.src.rpm

Release number changed.

Comment 11 Mamoru TASAKA 2009-01-27 19:13:30 UTC
Looks good, approving.

-------------------------------------------------------------
   This package (opencsv) is APPROVED by mtasaka
-------------------------------------------------------------

Comment 12 Sandro Mathys 2009-01-27 22:28:19 UTC
New Package CVS Request
=======================
Package Name: opencsv
Short Description: A very simple csv (comma-separated values) parser library for Java
Owners: red
Branches: F-9 F-10
InitialCC:

Comment 13 Kevin Fenzi 2009-01-28 05:45:00 UTC
cvs done.

Comment 14 Fedora Update System 2009-01-29 23:08:03 UTC
opencsv-1.8-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2009-01-29 23:09:08 UTC
opencsv-1.8-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.