Bug 475381
| Summary: | I fixed RTL problem in nodoka notification (patch is attached) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Muayyad Alsadi <alsadi> | ||||
| Component: | notification-daemon-engine-nodoka | Assignee: | Martin Sourada <martin.sourada> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 11 | CC: | martin.sourada | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-09-06 07:15:07 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Thanks for this fix. I'll probably add it to next release. Can you try this build? https://koji.fedoraproject.org/koji/buildinfo?buildID=76496 It contains a fix for the RTL problem, though slightly different from yours (I used gtk's functions instead of pango to check for the text direction)... I was about to replace my patch with something like what have you done as advised by Khalid Honey I downloaded that your .src.rpm (with http://) and compile it in F10 and it works fine thanks but I guess we should use gtk_widget_get_default_direction() instead of gtk_widget_get_direction(win) what do you thing ? Yes, that looks like a good idea. This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle. Changing version to '11'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping |
Created attachment 326232 [details] patch -p1 to fix RTL in notifications Description of problem: when one use standard notification or nodoka notification in RTL env (Arabic..etc.) it won't be very readable because the strip is drawn in the wrong place Version-Release number of selected component (if applicable): notification-daemon-engine-nodoka-0.1.0-3.fc10.src How reproducible: always this patch fixes both arrow/no arrow cases and does not affect non RTL languages