Bug 475661
| Summary: | Review Request: google-droid-fonts - General-purpose fonts released by Google as part of Android | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, feng.shaun, fonts-bugs, notting, oget.fedora, tremble |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0.112-3.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-16 22:09:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 472635, 475593 | ||
| Bug Blocks: | 446451 | ||
|
Description
Nicolas Mailhot
2008-12-09 22:56:58 UTC
I poked around this package for 2 hours now. I couldn't find any blockers. There are two minor things I think I should say: * Not a blocker but, as I say in all my reviews, I prefer using %defattr(-,root,root,-) * All fonts (including sans-serif ones) say that they are "Serif" as (OS/2) PFM-Family in fontforge. I think upstream needs notified. Other than these two, you might want to wait for the subpackage naming decision of FESCO for http://fedoraproject.org/wiki/PackagingDrafts/Font_package_naming_(2009-01-13) Otherwise, everything is clean ----------------------------------------------------- This package (google-droid-fonts) is APPROVED by oget ----------------------------------------------------- (In reply to comment #1) > I poked around this package for 2 hours now. I couldn't find any blockers. > There are two minor things I think I should say: > > * Not a blocker but, as I say in all my reviews, I prefer using > %defattr(-,root,root,-) For fonts an explicit defattr is part of the guidelines since there is no reason to have fonts with strange permissions installed :p > * All fonts (including sans-serif ones) say that they are "Serif" as (OS/2) > PFM-Family in fontforge. I think upstream needs notified. Missed this, nice to know, will do > Other than these two, you might want to wait for the subpackage naming decision > of FESCO for > http://fedoraproject.org/wiki/PackagingDrafts/Font_package_naming_(2009-01-13) Since the changes FPC requested didn't affect srpm naming, I'll do the cvs request now. > ----------------------------------------------------- > This package (google-droid-fonts) is APPROVED by oget > ----------------------------------------------------- Thank you! New Package CVS Request ======================= Package Name: google-droid-fonts Short Description: General-purpose fonts released by Google as part of Android Owners: nim Branches: F-9 F-10 InitialCC: fonts-sig cvs done. Will let it steam in rawhide a bit before importing in stable releases as it includes CJK fonts and we always seem to get them wrong at first somehow *** Bug 493240 has been marked as a duplicate of this bug. *** google-droid-fonts-1.0.112-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: google-droid-fonts New Branches: EL-6 Owners: tremble nim listed as welcoming EPEL maintainers. BTW if you have time to spend on the Fedora package, co-maintainers are welcome there too cvs done. |