Bug 475661 - Review Request: google-droid-fonts - General-purpose fonts released by Google as part of Android
Summary: Review Request: google-droid-fonts - General-purpose fonts released by Google...
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Orcan Ogetbil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
: 493240 (view as bug list)
Depends On: 472635 475593
Blocks: F11Target
TreeView+ depends on / blocked
 
Reported: 2008-12-09 22:56 UTC by Nicolas Mailhot
Modified: 2010-06-23 01:41 UTC (History)
6 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2009-01-16 22:09:32 UTC
oget.fedora: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Nicolas Mailhot 2008-12-09 22:56:58 UTC
Spec URL: http://nim.fedorapeople.org/fontpackages/google-droid-fonts.spec
SRPM URL: http://nim.fedorapeople.org/fontpackages/google-droid-fonts-1.0.112-1.fc11.src.rpm
Description:
The Droid typeface family was designed in the fall of 2006 by Ascender’s Steve Matteson, as a commission from Google to create a set of system fonts for its Android platform. The goal was to provide optimal quality and comfort on a mobile handset when rendered in application menus, web browsers and for other screen text.

http://fedoraproject.org/wiki/Google_Droid_fonts

Comment 1 Orcan Ogetbil 2009-01-14 19:30:21 UTC
I poked around this package for 2 hours now. I couldn't find any blockers. There are two minor things I think I should say:

* Not a blocker but, as I say in all my reviews, I prefer using %defattr(-,root,root,-)

* All fonts (including sans-serif ones) say that they are "Serif" as (OS/2) PFM-Family in fontforge. I think upstream needs notified.

Other than these two, you might want to wait for the subpackage naming decision of FESCO for
http://fedoraproject.org/wiki/PackagingDrafts/Font_package_naming_(2009-01-13)

Otherwise, everything is clean

-----------------------------------------------------
This package (google-droid-fonts) is APPROVED by oget
-----------------------------------------------------

Comment 2 Nicolas Mailhot 2009-01-14 21:53:36 UTC
(In reply to comment #1)
> I poked around this package for 2 hours now. I couldn't find any blockers.
> There are two minor things I think I should say:
> 
> * Not a blocker but, as I say in all my reviews, I prefer using
> %defattr(-,root,root,-)

For fonts an explicit defattr is part of the guidelines since there is no reason to have fonts with strange permissions installed :p

> * All fonts (including sans-serif ones) say that they are "Serif" as (OS/2)
> PFM-Family in fontforge. I think upstream needs notified.

Missed this, nice to know, will do

> Other than these two, you might want to wait for the subpackage naming decision
> of FESCO for
> http://fedoraproject.org/wiki/PackagingDrafts/Font_package_naming_(2009-01-13)

Since the changes FPC requested didn't affect srpm naming, I'll do the cvs request now.

> -----------------------------------------------------
> This package (google-droid-fonts) is APPROVED by oget
> -----------------------------------------------------

Thank you!

New Package CVS Request
=======================
Package Name: google-droid-fonts
Short Description: General-purpose fonts released by Google as part of Android
Owners: nim
Branches: F-9 F-10
InitialCC: fonts-sig

Comment 3 Kevin Fenzi 2009-01-15 20:26:50 UTC
cvs done.

Comment 4 Nicolas Mailhot 2009-01-16 22:09:32 UTC
Will let it steam in rawhide a bit before importing in stable releases as it includes CJK fonts and we always seem to get them wrong at first somehow

Comment 5 Rex Dieter 2009-04-01 14:17:37 UTC
*** Bug 493240 has been marked as a duplicate of this bug. ***

Comment 6 Fedora Update System 2009-04-15 18:02:41 UTC
google-droid-fonts-1.0.112-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Mark Chappell 2010-06-22 13:38:53 UTC
Package Change Request
======================
Package Name: google-droid-fonts
New Branches: EL-6
Owners: tremble    

nim listed as welcoming EPEL maintainers.

Comment 8 Nicolas Mailhot 2010-06-22 18:38:58 UTC
BTW if you have time to spend on the Fedora package, co-maintainers are welcome there too

Comment 9 Kevin Fenzi 2010-06-23 01:41:18 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.