Bug 476224

Summary: convert NFS to new write_begin/write_end interfaces
Product: Red Hat Enterprise Linux 5 Reporter: Jeff Layton <jlayton>
Component: kernelAssignee: Jeff Layton <jlayton>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: medium Docs Contact:
Priority: low    
Version: 5.3CC: dzickus, jbacik, jiali, staubach, steved
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-02 08:58:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 445433    
Bug Blocks:    
Attachments:
Description Flags
patch -- convert NFS to new aops
none
updated patch none

Description Jeff Layton 2008-12-12 16:07:10 UTC 
Josef has backported write_begin and write_end to RHEL5.4. While the old prepare/commit_write interfaces are still there, he's adding an extra page copy into that codepath to fix a deadlock. This will incur a performance penalty. To avoid it, we'll want to convert NFS to use the new extended aops.
Comment 1 Jeff Layton 2008-12-12 20:45:24 UTC 
Created attachment 326772 [details]
patch -- convert NFS to new aops

This patch builds cleanly, but needs testing.
Comment 2 Jeff Layton 2008-12-15 12:57:19 UTC 
Patch seems to work. I've done a bit of basic testing with it and haven't noticed any regressions. We'll certainly want to test it more extensively though, particularly in the write codepaths.
Comment 3 Jeff Layton 2009-01-09 20:22:36 UTC 
Created attachment 328585 [details]
updated patch

...to take into account the changes in Josef's patches
Comment 4 RHEL Program Management 2009-01-27 20:42:05 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 6 RHEL Program Management 2009-02-16 15:43:14 UTC 
Updating PM score.
Comment 8 Don Zickus 2009-04-20 17:11:20 UTC 
in kernel-2.6.18-140.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so.  However feel free
to provide a comment indicating that this fix has been verified.
Comment 11 errata-xmlrpc 2009-09-02 08:58:32 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1243.html