Josef has backported write_begin and write_end to RHEL5.4. While the old prepare/commit_write interfaces are still there, he's adding an extra page copy into that codepath to fix a deadlock. This will incur a performance penalty. To avoid it, we'll want to convert NFS to use the new extended aops.
Created attachment 326772 [details] patch -- convert NFS to new aops This patch builds cleanly, but needs testing.
Patch seems to work. I've done a bit of basic testing with it and haven't noticed any regressions. We'll certainly want to test it more extensively though, particularly in the write codepaths.
Created attachment 328585 [details] updated patch ...to take into account the changes in Josef's patches
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Updating PM score.
in kernel-2.6.18-140.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please do NOT transition this bugzilla state to VERIFIED until our QE team has sent specific instructions indicating when to do so. However feel free to provide a comment indicating that this fix has been verified.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-1243.html