Bug 476712
| Summary: | Package Review: lua-rex - Regular expression handling library for Lua | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Dave Cantrell <dcantrell> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | dcantrell, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | jkeating:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-06 00:11:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lubomir Rintel
2008-12-16 17:27:48 UTC
Builds in fedora-10-i386 mock, rpmlint silent and happy. Taking review. Should the .so files go in a -devel subpackage? License seems good Why isn't doc/ packaged in %doc ? Why aren't smp_flags used? What is the purpose of the manual lrexlib Provides? What will be Requiring that, other than the other auto-generated Provides: rex_onig.so.2.4 rex_pcre.so.2.4 rex_posix.so.2.4 lua-rex = 2.4.0-1.fc11 lua-rex(x86-32) = 2.4.0-1.fc11 (In reply to comment #3) > Should the .so files go in a -devel subpackage? No. They are not meant for use by linker, lua interpreter looks for .so files specifically. I'm thinking whether it makes sense to ship the .2.4 files, but it's that just because upstream does so. The .so files don't have a SONAME and are not used by dynamic linker, just dlopened by lua. > License seems good > > Why isn't doc/ packaged in %doc ? I just forgot. I'll be including it in new package I'll post shortly. > Why aren't smp_flags used? There's a comment. Or should I be more specific than just "doesn't work"? > What is the purpose of the manual lrexlib Provides? What will be Requiring > that, other than the other auto-generated Provides: > > rex_onig.so.2.4 > rex_pcre.so.2.4 > rex_posix.so.2.4 > lua-rex = 2.4.0-1.fc11 > lua-rex(x86-32) = 2.4.0-1.fc11 That's an upstream name. While it is desirable to name this package lua-rex, to denote it's a lua rex module there's a chance people will try to install it by doing "yum install lrexlib". If I remember correctly this is a recommended practice for perl modules, and I assumed it would be the same for lua. SPEC: http://netbsd.sk/~lkundrak/SPECS/lua-rex.spec SRPM: http://netbsd.sk/~lkundrak/SRPMS/lua-rex-2.4.0-2.el5.src.rpm * Wed Dec 17 2008 Lubomir Rintel <lkundrak> - 2.4.0-2 - Add doc directory to documentation - Allow parallel make runs Looks great now, approving. At some point you should probably bring a lua packaging guideline suggestion to the FPC since there are a few lua packages in now, and could be more coming. It'd speed up reviews. New Package CVS Request ======================= Package Name: lua-rex Short Description: Regular expression handling library for Lua Owners: lkundrak Branches: F-10 cvs done. |