Bug 476973
| Summary: | Review Request: eclipse-rpmstubby - Rpm specfile generator for Eclipse features | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-27 13:01:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alexander Kurtakov
2008-12-18 12:06:57 UTC
I made the review. There are a few minor things to go over: * Two Changelogs need packaged: ./org.eclipse.linuxtools.rpmstubby-feature/ChangeLog ./org.eclipse.linuxtools.rpmstubby/ChangeLog * I think URL needs to be: http://www.eclipse.org/linuxtools/projectPages/rpmstubby/ ? Could you provide a download location at the project homepage so we don't need to use this fetch script? * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT mixed. This needs corrected. You should also use %{__install} for consistency. * Summary looks awkward to me, maybe it should be shortened to: Rpm specfile generator for Eclipse These are all easy to do. I'm approving the package now. ---------------------------------------------------- This package (eclipse-rpmstubby) is APPROVED by oget ---------------------------------------------------- Spec URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby-0.1.0-1.fc10.src.rpm (In reply to comment #1) > I made the review. There are a few minor things to go over: > > * Two Changelogs need packaged: > ./org.eclipse.linuxtools.rpmstubby-feature/ChangeLog > ./org.eclipse.linuxtools.rpmstubby/ChangeLog > Fixed > * I think URL needs to be: > http://www.eclipse.org/linuxtools/projectPages/rpmstubby/ > Fixed > ? Could you provide a download location at the project homepage so we don't > need to use this fetch script? Not yet because the project needs to be reviewed from eclipse.org before making official releases. > > * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT > mixed. This needs corrected. You should also use %{__install} for consistency. > Fixed. > * Summary looks awkward to me, maybe it should be shortened to: > Rpm specfile generator for Eclipse > Current summary describes better what the plugin is doing. > > These are all easy to do. I'm approving the package now. > > > ---------------------------------------------------- > This package (eclipse-rpmstubby) is APPROVED by oget > ---------------------------------------------------- New Package CVS Request ======================= Package Name: eclipse-rpmstubby Short Description: Rpm specfile generator for Eclipse features Owners: akurtakov Branches: F-10 InitialCC: cvs done. Builded in rawhide now. |