Spec URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby-0.1.0-1.fc10.src.rpm Description: RPM Stubby Plug-in is a plugin aiming to auto-generate RPM specfile from feature.xml.
I made the review. There are a few minor things to go over: * Two Changelogs need packaged: ./org.eclipse.linuxtools.rpmstubby-feature/ChangeLog ./org.eclipse.linuxtools.rpmstubby/ChangeLog * I think URL needs to be: http://www.eclipse.org/linuxtools/projectPages/rpmstubby/ ? Could you provide a download location at the project homepage so we don't need to use this fetch script? * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT mixed. This needs corrected. You should also use %{__install} for consistency. * Summary looks awkward to me, maybe it should be shortened to: Rpm specfile generator for Eclipse These are all easy to do. I'm approving the package now. ---------------------------------------------------- This package (eclipse-rpmstubby) is APPROVED by oget ----------------------------------------------------
Spec URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby-0.1.0-1.fc10.src.rpm (In reply to comment #1) > I made the review. There are a few minor things to go over: > > * Two Changelogs need packaged: > ./org.eclipse.linuxtools.rpmstubby-feature/ChangeLog > ./org.eclipse.linuxtools.rpmstubby/ChangeLog > Fixed > * I think URL needs to be: > http://www.eclipse.org/linuxtools/projectPages/rpmstubby/ > Fixed > ? Could you provide a download location at the project homepage so we don't > need to use this fetch script? Not yet because the project needs to be reviewed from eclipse.org before making official releases. > > * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT > mixed. This needs corrected. You should also use %{__install} for consistency. > Fixed. > * Summary looks awkward to me, maybe it should be shortened to: > Rpm specfile generator for Eclipse > Current summary describes better what the plugin is doing. > > These are all easy to do. I'm approving the package now. > > > ---------------------------------------------------- > This package (eclipse-rpmstubby) is APPROVED by oget > ----------------------------------------------------
New Package CVS Request ======================= Package Name: eclipse-rpmstubby Short Description: Rpm specfile generator for Eclipse features Owners: akurtakov Branches: F-10 InitialCC:
cvs done.
Builded in rawhide now.