Bug 477818
| Summary: | Review Request: gsql - Integrated database development tool for GNOME | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Shevchuk <stlwrt> |
| Component: | Package Review | Assignee: | Lucian Langa <lucilanga> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, lucilanga, notting |
| Target Milestone: | --- | Flags: | lucilanga:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-02 21:12:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pavel Shevchuk
2008-12-23 22:13:20 UTC
RPMs built for Fedora 9 and 10, i386 and x86_64, with yum repodata: http://rpm.scwlab.com/fedora/gsql/ rpmlint is not silent: gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libxml2.so.2 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libdbus-glib-1.so.2 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /lib64/libdbus-1.so.3 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libatk-1.0.so.0 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /lib64/libgio-2.0.so.0 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libpangoft2-1.0.so.0 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libpangocairo-1.0.so.0 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libcairo.so.2 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libfreetype.so.6 gsql.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsql.so.0.0.0 /usr/lib64/libfontconfig.so.1 Please see : https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#unused-direct-shlib-dependency Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). It is not really necessary to call ldconfig on -plugin and -engine-mysql because no libraries are added on ldconfig search path. Sorry for the delay, i'm having exams this week. * Thu Jan 29 2009 Pavel "Stalwart" Shevchuk <stlwrt> - 0.2.1-2 - Added workaround for direct shlib dependency - Removed unneeded ldconfig call from plugins and engine-mysql - Added missing pkgconfig to devel requires New SPEC: http://rpm.scwlab.com/fedora/gsql/gsql.spec New SRPM: http://rpm.scwlab.com/fedora/gsql/10/x86_64/result/gsql-0.2.1-2.fc10.src.rpm Built RPMs for F10: http://rpm.scwlab.com/fedora/gsql/10/ OK source files match upstream:
faf236290f222df013198cb0e9cb8555 gsql-0.2.1.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK summary is OK.
OK description is OK.
OK dist tag is present.
OK build root is OK.
OK license field matches the actual license.
OK license is open source-compatible.
OK license text included in package.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (rawhide, x86_64).
OK package installs properly.
OK debuginfo package looks complete.
OK rpmlint is not silent.
gsql.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gsql.schemas
gsql-plugins.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gsql-plugins.schemas
gsql-engine-mysql.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gsql-engine-mysql.schemas
-Safe to ingore
gsql.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libgsql.so
gsql-plugins.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/plugins/libgsqlplugin_vte.so
gsql-plugins.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/plugins/libgsqlplugin_runner.so
gsql-plugins.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/plugins/libgsqlplugin_exporter.so
gsql-engine-mysql.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsql/engines/libgsqlengine_mysql.so
-Safe to igore as package uses g_load_module to load this so files.
OK final provides and requires are sane:
gsql-0.2.1-1.fc11.x86_64.rpm
libgsql.so.0()(64bit)
gsql = 0.2.1-2.fc11
gsql(x86-64) = 0.2.1-2.fc11
=
/bin/sh
GConf2
desktop-file-utils
gsql-engine-mysql = 0.2.1-2.fc11
libICE.so.6()(64bit)
libORBit-2.so.0()(64bit)
libSM.so.6()(64bit)
libart_lgpl_2.so.2()(64bit)
libatk-1.0.so.0()(64bit)
libbonobo-2.so.0()(64bit)
libbonobo-activation.so.4()(64bit)
libbonoboui-2.so.0()(64bit)
libc.so.6()(64bit)
libcairo.so.2()(64bit)
libdbus-1.so.3()(64bit)
libdbus-glib-1.so.2()(64bit)
libfontconfig.so.1()(64bit)
libfreetype.so.6()(64bit)
libgconf-2.so.4()(64bit)
libgdk-x11-2.0.so.0()(64bit)
libgdk_pixbuf-2.0.so.0()(64bit)
libgio-2.0.so.0()(64bit)
libglade-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgnome-2.so.0()(64bit)
libgnomecanvas-2.so.0()(64bit)
libgnomeui-2.so.0()(64bit)
libgnomevfs-2.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgsql.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libgtksourceview-2.0.so.0()(64bit)
libnotify.so.1()(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
libpangoft2-1.0.so.0()(64bit)
libpopt.so.0()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libxml2.so.2()(64bit)
gsql-devel-0.2.1-1.fc10.x86_64.rpm
pkgconfig(libgsql) = 0.2.1
gsql-devel = 0.2.1-2.fc11
gsql-devel(x86-64) = 0.2.1-2.fc11
=
/usr/bin/pkg-config
gsql = 0.2.1-2.fc11
pkgconfig
gsql-engine-mysql-0.2.1-2.fc11.x86_64.rpm
libgsqlengine_mysql.so.0()(64bit)
gsql-engine-mysql = 0.2.1-2.fc11
gsql-engine-mysql(x86-64) = 0.2.1-2.fc11
=
/bin/sh
gsql = 0.2.1-2.fc11
libc.so.6()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgsql.so.0()(64bit)
libgsqlengine_mysql.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libmysqlclient_r.so.16()(64bit)
gsql-plugins-0.2.1-2.fc11.x86_64.rpm
libgsqlplugin_exporter.so.0()(64bit)
libgsqlplugin_runner.so.0()(64bit)
libgsqlplugin_vte.so.0()(64bit)
gsql-plugins = 0.2.1-2.fc11
gsql-plugins(x86-64) = 0.2.1-2.fc11
=
/bin/sh
gsql = 0.2.1-2.fc11
libc.so.6()(64bit)
libgdk-x11-2.0.so.0()(64bit)
libgdk_pixbuf-2.0.so.0()(64bit)
libglade-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgsql.so.0()(64bit)
libgsqlplugin_exporter.so.0()(64bit)
libgsqlplugin_runner.so.0()(64bit)
libgsqlplugin_vte.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libvte.so.9()(64bit)
OK %check is not present; no test suite upstream.
OK shared libraries installed; ldconfig called properly
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK scriptlets present look OK
OK code, not content.
OK documentation is small, so no -doc subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers are in a separate -devel package.
OK pkgconfig files present; pkgconfig dependency present
OK no static libraries.
OK no libtool .la files.
OK desktop files valid and installed properly
Suggestion:
- please consider preserving timestamps of installed files
call make install with INSTALL="install -p"
APPROVED.
New Package CVS Request ======================= Package Name: gsql Short Description: Integrated database development tool for GNOME Owners: stalwart Branches: F-9 F-10 InitialCC: cvs done. Spec imported to cvs, packages built in koji. Thanks Lucian and Kevin, i appreciate your help |