Bug 477941

Summary: doesn't respect trough-side-details
Product: [Fedora] Fedora Reporter: Matthias Clasen <mclasen>
Component: gtk-nodoka-engineAssignee: Martin Sourada <martin.sourada>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: jmccann, martin.sourada
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.7.2-5.fc10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-31 17:46:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Proposed Solution 1 none

Description Matthias Clasen 2008-12-26 03:01:54 UTC
I was looking at turning off the filled in appearance of the lower half of the trough in scales for the 'fade' control in the new volume applet, since it is not appropriate there. 

GTK+ has a GtkRange::trough-side-details style property that is supposed to control the ability of theme engines to differentiate between lower and upper half of the trough by passing in different details. 

Clearlooks uses this mechanism, and consequently it is possible to turn off the filled in appearance by overriding the style property in the application. 

Nodoka on the other hand, finds the adjustment value, and bases its fill drawing on that. Manually poking at the innards of the widget like that from a theme engine is bad. Nodoka should respect the trough-side-details style property and 
base its fill drawing on the detail string: trough-lower vs trough-upper.

Comment 1 Martin Sourada 2008-12-26 10:53:44 UTC
Thanks for the catch. I'll look at it later today or tomorrow (hopefully).

Comment 2 Martin Sourada 2008-12-26 23:01:49 UTC
Created attachment 327869 [details]
Proposed Solution 1

I've just finished first approach on this matter. Can you try if it works with this patch as expected?

Comment 3 Martin Sourada 2008-12-30 17:04:47 UTC
Package with this patch applied has just finished building for rawhide. I think it behaves now as expected, but would like you to check it as well before closing the bug. Thanks.

http://koji.fedoraproject.org/koji/buildinfo?buildID=76747

Comment 4 Matthias Clasen 2008-12-30 20:42:53 UTC
I will test it when I'm back in rawhide, thanks.

Comment 5 Matthias Clasen 2008-12-31 16:44:26 UTC
Works fine, thanks.

Comment 6 Fedora Update System 2009-07-24 12:20:42 UTC
gtk-nodoka-engine-0.7.2-5.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/gtk-nodoka-engine-0.7.2-5.fc10

Comment 7 Fedora Update System 2009-08-15 08:07:37 UTC
gtk-nodoka-engine-0.7.2-5.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.