Bug 478928
Summary: | Review Request: globus-rsl-assist - Globus Toolkit - RSL Manipulation Library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 2.1-1.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-05-02 16:29:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 453847, 453848, 478927 | ||
Bug Blocks: |
Description
Mattias Ellert
2009-01-06 01:16:21 UTC
New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-rsl-assist-2.1-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-rsl-assist.spec Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rsl-assist-2.1-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rsl-assist.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus I finished reviewing this. There is only one issue that I need to ask: ? This one has doxygen documentation. Any reasons for not building/packaging it? The package build fine in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1318281 There are comments in the headers describing the API, but they are not proper doxygen markup. It is possible to build the package with the instructions to generate a doc package, but it will be rather empty: /usr/share/doc/globus-rsl-assist-2.1/html /usr/share/doc/globus-rsl-assist-2.1/html/doxygen.css /usr/share/doc/globus-rsl-assist-2.1/html/doxygen.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2blank.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2doc.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2folderclosed.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2folderopen.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2lastnode.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2link.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2mlastnode.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2mnode.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2node.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2plastnode.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2pnode.png /usr/share/doc/globus-rsl-assist-2.1/html/ftv2vertline.png /usr/share/doc/globus-rsl-assist-2.1/html/globus_rsl_assist.tag /usr/share/doc/globus-rsl-assist-2.1/html/graph_legend.dot /usr/share/doc/globus-rsl-assist-2.1/html/graph_legend.html /usr/share/doc/globus-rsl-assist-2.1/html/graph_legend.png /usr/share/doc/globus-rsl-assist-2.1/html/index.html /usr/share/doc/globus-rsl-assist-2.1/html/main.html /usr/share/doc/globus-rsl-assist-2.1/html/tab_b.gif /usr/share/doc/globus-rsl-assist-2.1/html/tab_l.gif /usr/share/doc/globus-rsl-assist-2.1/html/tab_r.gif /usr/share/doc/globus-rsl-assist-2.1/html/tabs.css /usr/share/doc/globus-rsl-assist-2.1/html/tree.html /usr/share/doc/globus-rsl-assist-2.1/refman.pdf /usr/share/globus/packages/globus_rsl_assist/noflavor_doc.filelist /usr/share/globus/packages/globus_rsl_assist/pkg_data_noflavor_doc.gpt As you can see there are no section 3 man pages, nor any html pages with content - only the empty stub created by doxygen. The pdf manual only has the frontpage and an empty content page. So the doc package is possible to produce, but is rather useless. No need to produce it if it is useless. But take a note somewhere in case things change with the next upstream release. ---------------------------------------------------- This package (globus-rsl-assist) is APPROVED by oget ---------------------------------------------------- Thank you for the review. I will definitely check if the documentation is buildable in new releases. New Package CVS Request ======================= Package Name: globus-rsl-assist Short Description: Globus Toolkit - RSL Manipulation Library Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC: cvs done. globus-rsl-assist-2.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-rsl-assist-2.1-1.fc10 globus-rsl-assist-2.1-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-rsl-assist-2.1-1.fc9 globus-rsl-assist-2.1-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. globus-rsl-assist-2.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. globus-rsl-assist-2.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-rsl-assist-2.1-1.fc11 globus-rsl-assist-2.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |