Bug 479527 (synfigstudio)
| Summary: | Review Request: synfigstudio - Vector-based 2D animation studio | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Luya Tshimbalanga <luya> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, hicham.haouari, luya, notting, pahan |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | luya:
fedora-review+
j: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-19 17:45:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 531773 | ||
| Bug Blocks: | |||
|
Description
Lubomir Rintel
2009-01-10 17:33:33 UTC
Here is review: + $ rpmlint Downloads/synfigstudio-0.61.09-1.el5.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. + spec and source file matches the package name and comply with Package Naming Guideline + License is GPLv2 + Spec file is legible and written in American English + Package is a GUI application. desktop-file-utils requirement is provided and .desktop is used as required by Packaging Guideline + $ md5sum rpmbuild/SOURCES/synfigstudio-0.61.09.tar.gz Downloads/synfigstudio-0.61.09.tar.gz 09dac04ce8b6b8ac0ff15fde4b041eed rpmbuild/SOURCES/synfigstudio-0.61.09.tar.gz 09dac04ce8b6b8ac0ff15fde4b041eed Downloads/synfigstudio-0.61.09.tar.gz Downloads path is taken from upstream thus match the source package from src file. + Usage of Macros are consistent in spec file + Source URL matches upstream and is fully functional + All .la are excluded from the package + The package owns directory and files it creates + Package is succesfully compiled and build with synfig devel package from #531773. No sure if I should let pass synfigstudio because of missing synfig-devel otherwise it can be accepted once synfig package is available on repository. Further review:
+ Each files section is include in %deffrag{...} and permission are properly set.
+ Header files are in -devel package
+ On spec file, base package is required in -devel package
+ Filenames are valid UTF-8
Since synfig version is 0.62 on Koji, using koji will fail on this current version. However, the resulting built from previous version synfig used for review was successful on my local machine. the application is fully functional and can be removed without issue.
In conclusion, synfigstudio fully complies with Packaging Guideline.
Make sure to update this package in 0.62.
Thank you. New Package CVS Request ======================= Package Name: synfigstudio Short Description: Vector-based 2D animation studio Owners: lkundrak Branches: F-11 F-12 EL-5 CVS done. Hicham, please don't close review requests that haven't been completed (i.e. the package is not yet imported and built). This was built just now. |