Bug 479527 (synfigstudio) - Review Request: synfigstudio - Vector-based 2D animation studio
Summary: Review Request: synfigstudio - Vector-based 2D animation studio
Alias: synfigstudio
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Luya Tshimbalanga
QA Contact: Fedora Extras Quality Assurance
Depends On: 531773
TreeView+ depends on / blocked
Reported: 2009-01-10 17:33 UTC by Lubomir Rintel
Modified: 2010-01-03 15:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-12-19 17:45:35 UTC
Type: ---
luya: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)

Description Lubomir Rintel 2009-01-10 17:33:33 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/synfigstudio.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/synfigstudio-0.61.09-1.el5.src.rpm


Synfig Animation Studio is a powerful, industrial-strength vector-based
2D animation software, designed from the ground-up for producing
feature-film quality animation with fewer people and resources.
It is designed to be capable of producing feature-film quality
animation. It eliminates the need for tweening, preventing the
need to hand-draw each frame. Synfig features spatial and temporal
resolution independence (sharp and smoothat any resolution or framerate),
high dynamic range images, and a flexible plugin system.

This package contains the GUI-based animation studio.

Comment 1 Luya Tshimbalanga 2009-11-13 04:26:43 UTC
Here is review:

+ $ rpmlint Downloads/synfigstudio-0.61.09-1.el5.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ spec and source file matches the package name and comply with Package Naming Guideline

+ License is GPLv2

+ Spec file is legible and written in American English

+ Package is a GUI application. desktop-file-utils requirement is provided and .desktop is used as required by Packaging Guideline

+ $ md5sum rpmbuild/SOURCES/synfigstudio-0.61.09.tar.gz Downloads/synfigstudio-0.61.09.tar.gz 
09dac04ce8b6b8ac0ff15fde4b041eed  rpmbuild/SOURCES/synfigstudio-0.61.09.tar.gz
09dac04ce8b6b8ac0ff15fde4b041eed  Downloads/synfigstudio-0.61.09.tar.gz

Downloads path is taken from upstream thus match the source package from src file.

+ Usage of Macros are consistent in spec file

+ Source URL matches upstream and is fully functional

+ All .la are excluded from the package

+ The package owns directory and files it creates

+ Package is succesfully compiled and build with synfig devel package from #531773. No sure if I should let pass synfigstudio because of missing synfig-devel otherwise it can be accepted once synfig package is available on repository.

Comment 2 Luya Tshimbalanga 2009-11-14 23:18:48 UTC
Further review:

+ Each files section is include in %deffrag{...} and permission are properly set.

+ Header files are in -devel package

+ On spec file, base package is required in -devel package

+ Filenames are valid UTF-8

Since synfig version is 0.62 on Koji, using koji will fail on this current version. However, the resulting built from previous version synfig used for review was successful on my local machine. the application is fully functional and can be removed without issue.

In conclusion, synfigstudio fully complies with Packaging Guideline. 
Make sure to update this package in 0.62.

Comment 3 Lubomir Rintel 2009-11-15 11:18:39 UTC
Thank you.

New Package CVS Request
Package Name: synfigstudio
Short Description: Vector-based 2D animation studio
Owners: lkundrak
Branches: F-11 F-12 EL-5

Comment 4 Jason Tibbitts 2009-11-16 17:44:04 UTC
CVS done.

Comment 5 Lubomir Rintel 2009-12-20 13:08:43 UTC
Hicham, please don't close review requests that haven't been completed (i.e. the package is not yet imported and built).

This was built just now.

Note You need to log in before you can comment on or make changes to this bug.