Bug 480091
| Summary: | Review Request: perl-MooseX-Types-DateTime - DateTime related constraints and coercions for Moose | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/MooseX-Types-DateTime | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-16 02:51:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Weyl
2009-01-14 23:41:13 UTC
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1054070 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a270e7d20c23ef23ee782563187d93c5 MooseX-Types-DateTime-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave skipped: DateTime::Format::DateManip required All tests successful. Files=2, Tests=21, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.36 cusr 0.02 csys = 0.38 CPU) + Package perl-MooseX-Types-DateTime-0.03-2.fc11 => Provides: perl(MooseX::Types::DateTime) = 0.03 perl(MooseX::Types::DateTimeX) Requires: perl(DateTime) perl(DateTime::Duration) perl(DateTime::Locale) perl(DateTime::TimeZone) perl(DateTimeX::Easy) perl(MooseX::Types) perl(MooseX::Types::DateTime) perl(MooseX::Types::Moose) perl(Time::Duration::Parse) perl(namespace::clean) perl(strict) perl(warnings) Suggestions: 1) you can enable test by adding perl-DateTime-Format-DateManip as BR APPROVED. New Package CVS Request ======================= Package Name: perl-MooseX-Types-DateTime Short Description: DateTime related constraints and coercions for Moose Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig cvs done. Thanks for the review! :-) |