Bug 480091 - Review Request: perl-MooseX-Types-DateTime - DateTime related constraints and coercions for Moose
Review Request: perl-MooseX-Types-DateTime - DateTime related constraints and...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://search.cpan.org/dist/MooseX-Ty...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-14 18:41 EST by Chris Weyl
Modified: 2009-01-15 21:51 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-15 21:51:23 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2009-01-14 18:41:13 EST
Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Types-DateTime.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Types-DateTime-0.03-2.fc10.src.rpm

Description:
This module packages several Moose::Util::TypeConstraints with coercions
designed to work with the DateTime suite of objects.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1054070
Comment 1 Parag AN(पराग) 2009-01-14 23:59:25 EST
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1054070
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a270e7d20c23ef23ee782563187d93c5  MooseX-Types-DateTime-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
skipped: DateTime::Format::DateManip required
All tests successful.
Files=2, Tests=21,  0 wallclock secs ( 0.00 usr  0.00 sys +  0.36 cusr  0.02 csys =  0.38 CPU)
+ Package perl-MooseX-Types-DateTime-0.03-2.fc11 =>
  Provides: perl(MooseX::Types::DateTime) = 0.03 perl(MooseX::Types::DateTimeX)
  Requires: perl(DateTime) perl(DateTime::Duration) perl(DateTime::Locale) perl(DateTime::TimeZone) perl(DateTimeX::Easy) perl(MooseX::Types) perl(MooseX::Types::DateTime) perl(MooseX::Types::Moose) perl(Time::Duration::Parse) perl(namespace::clean) perl(strict) perl(warnings)

Suggestions:
1) you can enable test by adding perl-DateTime-Format-DateManip as BR

APPROVED.
Comment 2 Chris Weyl 2009-01-15 00:46:51 EST
New Package CVS Request
=======================
Package Name: perl-MooseX-Types-DateTime
Short Description: DateTime related constraints and coercions for Moose
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC: perl-sig
Comment 3 Kevin Fenzi 2009-01-15 15:48:06 EST
cvs done.
Comment 4 Chris Weyl 2009-01-15 21:51:23 EST
Thanks for the review! :-)

Note You need to log in before you can comment on or make changes to this bug.