Bug 480504

Summary: RTLD_DEEPBIND may crash pulseaudio
Product: [Fedora] Fedora Reporter: Jan Kratochvil <jan.kratochvil>
Component: xine-libAssignee: Aurelien Bompard <gauret>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: gauret, ghosler, kevin, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-27 01:50:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Testcase for RTLD_DEEPBIND unrealted to xine-lib. none

Description Jan Kratochvil 2009-01-17 22:26:30 UTC 
Created attachment 329291 [details]
Testcase for RTLD_DEEPBIND unrealted to xine-lib.

Description of problem:
Filing here a Bug originally reported by Gregory Hosler.
xine-lib can crash in pulseaudio due to its (upstream fixed) Bug
http://www.pulseaudio.org/changeset/701384935446a5705cb77a9da2f896b086a392be
But this Bug would not occur if xine-lib would not use RTLD_DEEPBIND in its patch `xine-lib-1.1.1-deepbind-939.patch' (cannot find any Bug number 939).
http://cvs.fedora.redhat.com/viewvc/rpms/xine-lib/devel/xine-lib-1.1.1-deepbind-939.patch?revision=1.1
While I did not try xine-lib myself without this patch there are given no reasons in the .spec file for it.  Could be this patch removed?

This Bug occurs as RTLD_DEEPBIND makes the `environ' variable NULL.  Without RTLD_DEEPBIND such unusual (despite valid) state would not occur.

Version-Release number of selected component (if applicable):
xine-lib-1.1.16-1.1 (src)

Attaching a bit unrelated testcase (deepbind-environ) showing `environ' gets cleared due to RTLD_DEEPBIND.
Comment 1 Rex Dieter 2009-01-18 20:34:27 UTC 
Interesting.

I'm unfamiliar with the history too, but this seems to be it:
http://bugzilla.livna.org/show_bug.cgi?id=939
Comment 2 Kevin Kofler 2009-01-18 20:41:30 UTC 
Looks like the right fix there would be to get xine-lib-extras-freeworld to also use the system libfaad, if this isn't already done. Then we can get rid of that hack.
Comment 3 Rex Dieter 2009-01-18 21:07:09 UTC 
Yup, beat me to it.

Just committed changes doing just that (for rawhide/f11 anyway).  Provided the builds complete and nothing blows up, we'll consider doing so for other branches as well.
Comment 4 Jan Kratochvil 2009-01-18 21:13:44 UTC 
Nice it found a library duplicity, thanks.
Comment 5 Fedora Update System 2009-01-24 02:34:39 UTC 
xine-lib-1.1.16.1-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xine-lib'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0884
Comment 6 Fedora Update System 2009-01-27 01:50:10 UTC 
xine-lib-1.1.16.1-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.