Bug 481004 (pg_top)
| Summary: | Review Request: pg_top - top for postgresql | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Itamar Reis Peixoto <itamar> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 3.6.2-3.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-05 16:28:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Itamar Reis Peixoto
2009-01-21 17:24:58 UTC
Review
=======
Good:
- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, matches source
- spec file legible, in am. english
- source matches upstream (338bc398ace91a05af769f6b555cce89ba997fbe)
- package compiles on devel (x86_64)
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- macro use consistent
- code, not content
- no need for .desktop file
Bad:
* Package is not using %{optflags} during compilation.
* There is no packaged documentation aside from the manpage
* The license text is not packaged as %doc
* %defattr(-,root,root) is used instead of %defattr(-,root,root,-)
* Patch1 is completely pointless.
* Missing BuildRequires: elfutils-libelf-devel
Please fix these issues and show a new SRPM.
done. http://ispbrasil.com.br/pg_top/pg_top.spec http://ispbrasil.com.br/pg_top/pg_top-3.6.2-3.fc10.src.rpm Looks good, approved. New Package CVS Request ======================= Package Name: pg_top Short Description: pg_top is 'top' for PostgreSQL processes Owners: itamarjp Branches: F-10 F-9 InitialCC: cvs done. pg_top-3.6.2-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pg_top'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1006 Please go ahead and push this into stable. No one is going to test a brand new package. pg_top-3.6.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. last time (redir), the cvs admin forget EL-4 asking both, EL-4 and EL-5 for pg_top Package Change Request ====================== Package Name: pg_top New Branches: EL-4 EL-5 Owners: itamarjp last time (redir), the cvs admin forget EL-4 asking both, EL-4 and EL-5 for pg_top Package Change Request ====================== Package Name: pg_top New Branches: EL-4 EL-5 Owners: itamarjp atorkhov Sorry about that on redir, should be fixed now. I didn't 'forget' it, it was a typo. ;( cvs done. thanks, |