Bug 481004 (pg_top) - Review Request: pg_top - top for postgresql
Summary: Review Request: pg_top - top for postgresql
Keywords:
Status: CLOSED NEXTRELEASE
Alias: pg_top
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-01-21 17:24 UTC by Itamar Reis Peixoto
Modified: 2009-09-25 17:50 UTC (History)
3 users (show)

Fixed In Version: 3.6.2-3.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-05 16:28:35 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Itamar Reis Peixoto 2009-01-21 17:24:58 UTC
Spec URL: http://ispbrasil.com.br/pg_top/pg_top.spec
SRPM URL: http://ispbrasil.com.br/pg_top/pg_top-3.6.2-2.fc11.src.rpm
Description: 

pg_top is 'top' for PostgreSQL processes. See running queries,
query plans, issued locks, and table and index statistics.

koji scratch build

http://koji.fedoraproject.org/koji/taskinfo?taskID=1071512

Comment 1 Tom "spot" Callaway 2009-01-21 19:12:59 UTC
Review
=======

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, matches source
- spec file legible, in am. english
- source matches upstream (338bc398ace91a05af769f6b555cce89ba997fbe)
- package compiles on devel (x86_64)
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- macro use consistent
- code, not content
- no need for .desktop file

Bad:

* Package is not using %{optflags} during compilation.
* There is no packaged documentation aside from the manpage
* The license text is not packaged as %doc
* %defattr(-,root,root) is used instead of %defattr(-,root,root,-)
* Patch1 is completely pointless.
* Missing BuildRequires: elfutils-libelf-devel

Please fix these issues and show a new SRPM.

Comment 3 Tom "spot" Callaway 2009-01-21 20:52:21 UTC
Looks good, approved.

Comment 4 Itamar Reis Peixoto 2009-01-21 21:00:26 UTC
New Package CVS Request
=======================
Package Name: pg_top
Short Description: pg_top is 'top' for PostgreSQL processes
Owners: itamarjp
Branches: F-10 F-9
InitialCC:

Comment 5 Kevin Fenzi 2009-01-23 23:33:47 UTC
cvs done.

Comment 6 Fedora Update System 2009-01-27 01:52:20 UTC
pg_top-3.6.2-3.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pg_top'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1006

Comment 7 Tom "spot" Callaway 2009-03-04 22:29:49 UTC
Please go ahead and push this into stable. No one is going to test a brand new package.

Comment 8 Fedora Update System 2009-03-05 16:28:27 UTC
pg_top-3.6.2-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Itamar Reis Peixoto 2009-09-25 17:37:21 UTC
last time (redir), the cvs admin forget EL-4

asking  both, EL-4 and EL-5 for pg_top


Package Change Request
======================
Package Name: pg_top
New Branches: EL-4 EL-5
Owners: itamarjp

Comment 10 Itamar Reis Peixoto 2009-09-25 17:48:02 UTC
last time (redir), the cvs admin forget EL-4

asking  both, EL-4 and EL-5 for pg_top


Package Change Request
======================
Package Name: pg_top
New Branches: EL-4 EL-5
Owners: itamarjp atorkhov

Comment 11 Kevin Fenzi 2009-09-25 17:48:51 UTC
Sorry about that on redir, should be fixed now. I didn't 'forget' it, it was a typo. ;( 

cvs done.

Comment 12 Itamar Reis Peixoto 2009-09-25 17:50:09 UTC
thanks,


Note You need to log in before you can comment on or make changes to this bug.