Bug 481573
| Summary: | Review Request: code2html - Covert source code to HTML | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rakesh Pandit <rpandit> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-27 03:17:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rakesh Pandit
2009-01-26 14:37:35 UTC
Review: + package builds in mock (rawhide i386). koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1083165 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 368377696547026c79c51a274571dc39 latest.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Suggestions: 1) License is MIT(Modern Style with sublicense) not BSD. 2) use -p in install command to preserve timestamps. APPROVED. Thanks, I have updated in accordance with both of points mentioned: http://rakesh.fedorapeople.org/spec/code2html.spec http://rakesh.fedorapeople.org/srpm/code2html-0.9.1-2.fc10.src.rpm New Package CVS Request ======================= Package Name: code2html Short Description: Covert source code to HTML Owners: rakesh Branches: F-8 F-9 F-10 InitialCC: Cvsextras Commits: yes F-8 is end of life and no longer supported. cvs done otherwise. |