Bug 481573 - Review Request: code2html - Covert source code to HTML
Summary: Review Request: code2html - Covert source code to HTML
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-01-26 14:37 UTC by Rakesh Pandit
Modified: 2009-01-27 18:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-27 03:17:15 UTC
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Rakesh Pandit 2009-01-26 14:37:35 UTC
Description:
Code2HTML converts a program source code to syntax highlighted HTML.

SPEC: http://rakesh.fedorapeople.org/spec/code2html.spec
SRPM: http://rakesh.fedorapeople.org/srpm/code2html-0.9.1-1.fc10.src.rpm

Comment 1 Parag AN(पराग) 2009-01-26 15:31:49 UTC
Review:
+ package builds in mock (rawhide i386).
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1083165
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
368377696547026c79c51a274571dc39  latest.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

Suggestions:
1) License is MIT(Modern Style with sublicense) not BSD.
2) use -p in install command to preserve timestamps.

 APPROVED.

Comment 2 Rakesh Pandit 2009-01-26 15:59:56 UTC
Thanks, I have updated in accordance with both of points mentioned:
http://rakesh.fedorapeople.org/spec/code2html.spec
http://rakesh.fedorapeople.org/srpm/code2html-0.9.1-2.fc10.src.rpm

New Package CVS Request
=======================
Package Name: code2html
Short Description: Covert source code to HTML
Owners: rakesh
Branches: F-8 F-9 F-10
InitialCC:
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2009-01-26 23:05:17 UTC
F-8 is end of life and no longer supported. 

cvs done otherwise.


Note You need to log in before you can comment on or make changes to this bug.