Hide Forgot
Description: Code2HTML converts a program source code to syntax highlighted HTML. SPEC: http://rakesh.fedorapeople.org/spec/code2html.spec SRPM: http://rakesh.fedorapeople.org/srpm/code2html-0.9.1-1.fc10.src.rpm
Review: + package builds in mock (rawhide i386). koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1083165 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 368377696547026c79c51a274571dc39 latest.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Suggestions: 1) License is MIT(Modern Style with sublicense) not BSD. 2) use -p in install command to preserve timestamps. APPROVED.
Thanks, I have updated in accordance with both of points mentioned: http://rakesh.fedorapeople.org/spec/code2html.spec http://rakesh.fedorapeople.org/srpm/code2html-0.9.1-2.fc10.src.rpm New Package CVS Request ======================= Package Name: code2html Short Description: Covert source code to HTML Owners: rakesh Branches: F-8 F-9 F-10 InitialCC: Cvsextras Commits: yes
F-8 is end of life and no longer supported. cvs done otherwise.