Bug 483033

Summary:	Review Request: pinentry - Collection of simple PIN or passphrase entry dialogs
Product:	Red Hat Enterprise Linux 5	Reporter:	Peter Vrabec <pvrabec>
Component:	Package Review	Assignee:	Miloslav Trmač <mitr>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.0	CC:	iboverma, mitr, notting, pm-rhel
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-04-01 09:04:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	188273, 484188, 484234

Description Peter Vrabec 2009-01-29 13:07:17 UTC

Spec URL: http://people.redhat.com/pvrabec/gnupg2/pinentry.spec
SRPM URL: http://people.redhat.com/pvrabec/gnupg2/pinentry-0.7.3-2.fc9.src.rpm

Description: 
Pinentry is a collection of simple PIN or passphrase entry dialogs which
utilize the Assuan protocol as described by the aegypten project; see
http://www.gnupg.org/aegypten/ for details.
This package contains the GTK+ GUI based version of the PIN entry dialog.

Comment 1 Miloslav Trmač 2009-01-29 19:45:33 UTC

* rpmlint output:
pinentry.x86_64: W: dangling-symlink /usr/bin/pinentry /etc/alternatives/pinentry
pinentry.x86_64: W: symlink-should-be-relative /usr/bin/pinentry /etc/alternatives/pinentry
(same warnings for the two other binary packages)
This symlink is a %ghost, so the contents of the symlink don't matter.

* blocker: Source* is inaccessible - use ftp:// instead of http://

(* should: upstream comment about pinentry-info.patch -- but looking at 0.7.4 in Fedora, the patch was accepted upstream, so it's not necessary to worry about it)

* blocker: install-info should be in %preun, not %postun
  I'm not sure about update-alternatives, but I don't think moving it to %preun
  as well would hurt.

* blocker: pinentry-gtk contains /usr/bin/pinentry-gtk, which is a symlink
  to a non-existent pinentry-gtk-2

Comment 2 Peter Vrabec 2009-02-04 18:58:53 UTC

Spec URL: http://people.redhat.com/pvrabec/gnupg2/pinentry.spec
SRPM URL: http://people.redhat.com/pvrabec/gnupg2/pinentry-0.7.3-3.fc9.src.rpm

I was not able to reproduce symlink problem, but I add pinentry-gtk-2 entry into  gtk files section. So, if the problem appears again, it we will catch during package build.

* Tue Feb 03 2009 Peter Vrabec <pvrabec> - 0.7.3-3
- fix source url
- move postun to preun, mainly because of install-info
- add pinentry-gtk-2 entry into gtk files section

Comment 3 Miloslav Trmač 2009-02-06 11:01:07 UTC

Thanks.

The s/postun/preun change is incomplete: s/Requires(postun)/Requires(preun)/g .

Conditionally approved, assuming the above is fixed.

Comment 4 Peter Vrabec 2009-03-27 12:58:53 UTC

pinentry-0.7.3-3.el5 was built
https://brewweb.devel.redhat.com/buildinfo?buildID=83209