Bug 483039

Summary: wrong initscript behaviour
Product: Red Hat Enterprise Linux 4 Reporter: Karel Volný <kvolny>
Component: netdumpAssignee: Neil Horman <nhorman>
Status: CLOSED WONTFIX QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: low    
Version: 4.8   
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-07 16:27:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 237789    
Attachments:
Description Flags
patch to correct initscript behavior none

Description Karel Volný 2009-01-29 13:45:20 UTC 
Description of problem:
when the service is not configured, trying to start the service, the netdump initscript does not return error code 6 which should be used in that case (according to http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html)

the initscript even does not output the usage message in that case

in addition, the initscript refuses to do any other action if the configuration file is completely missing, and just returns zero for any action

the status return code for stopped service is 0 while it should be 3

Version-Release number of selected component (if applicable):
netdump-0.7.16-15

How reproducible:
always

Steps to Reproduce:
1. remove NETDUMPADDR record from /etc/sysconfig/netdump
2. service netdump start; echo $?
3. service netdump; echo $?
4. rm /etc/sysconfig/netdump
5. service netdump; echo $?
6. echo "NETDUMPADDR=server" > /etc/sysconfig/netdump
7. service netdump status; echo $?

Actual results:
Server address not specified in /etc/sysconfig/netdump
1
Server address not specified in /etc/sysconfig/netdump
1
0
netdump module not loaded
netconsole module not loaded
0

Expected results:
Server address not specified in /etc/sysconfig/netdump
6
Usage: service netdump {start|stop|status|restart|condrestart|propagate}
2
Usage: service netdump {start|stop|status|restart|condrestart|propagate}
2
netdump module not loaded
netconsole module not loaded
3


Additional info:
see also http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html
Comment 1 Karel Volný 2009-02-10 11:57:17 UTC 
I made a RHTS test for the iniscript behaviour: /CoreOS/netdump/Regression/bz483039-initscript - review welcome ...
Comment 4 Neil Horman 2009-09-16 13:02:35 UTC 
Created attachment 361273 [details]
patch to correct initscript behavior

please give that  a try and let me know if it passes the RHTS test
Comment 5 Karel Volný 2010-02-25 14:38:17 UTC 
(In reply to comment #4)
> Created an attachment (id=361273) [details]
> patch to correct initscript behavior
> 
> please give that  a try and let me know if it passes the RHTS test

yep, a lot better but there are still some problems:

- the Usage message does not mention the "reload" action

- the test with unprivileged user fails

- the initscript does not check for the stale lock

and the -server initscript was left untouched ...

but as RHEL-4 is nearly dead (ahem :-)) and I don't see netdump in RHEL-6 nor recent Fedora to propagate the changes forward, I'm not sure if that is worth fixing - if a update is ever going to be released, let's include this patch
Comment 6 RHEL Program Management 2010-10-22 18:48:57 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated in the
current release, Red Hat is unfortunately unable to address this
request at this time. Red Hat invites you to ask your support
representative to propose this request, if appropriate and relevant,
in the next release of Red Hat Enterprise Linux.
Comment 7 Neil Horman 2011-01-05 15:55:20 UTC 
Karel, can this be closed as a wontfix, its looking like we're not going to pull this into 4.9
Comment 8 Karel Volný 2011-01-07 15:26:55 UTC 
(In reply to comment #7)
> Karel, can this be closed as a wontfix, its looking like we're not going to
> pull this into 4.9

if there is no netdump update planned in RHEL4 then yes, closing this is the best thing to do