Bug 483360
| Summary: | Review Request: pdfshuffler - PDF file merging, rearranging, and spliting | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Milos Jakubicek <xjakub> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, xjakub |
| Target Milestone: | --- | Flags: | xjakub:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3.1-3.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-05 16:28:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-01-30 22:44:22 UTC
MUST:
+ rpmlint is silent
+ package name
+ spec file name
- packaging guidelines
- "The summary should be a short and concise description of the package"
? "A desktop diary" -- left from different spec file ? :)
+ Python guidelines:
+ defines %{python_sitelib}
+ builds egg from source
+ egg_info included
+ no unnecessary pyc/pyo
+ license (GPLv2+) ok, in COPYING as well in source files
+ spec file legible, English
+ source matches upstream (md5sum c59f3efcbc448c39fabbaac70c4237d4)
+ architectures ok (noarch)
+ builds in mock, no unnecessary BR
+ no need to ldconfig
+ locales ok (uses find_lang)
+ no library, hence no devel, static etc.
+ not relocatable
+ directories ownership ok
+ no dups in %files, proper %clean, %install
+ macros consistent
+ code and perm. content
+ %docs present
+ UTF-8
SHOULD:
+ license file
+ it works!:)
OTHERS:
- if you already insist on proper English grammar when patching (which is great!), do it proper;)
from the desktop file patch:
"Comment=PDF Merging, Rearranging, and Spliting"
^
Provided that you fix the summary (and the patch typo:) when importing, this package is APPROVED.
Thanks for the review and finding the typo. (In reply to comment #1) > - packaging guidelines > - "The summary should be a short and concise description of the package" > ? "A desktop diary" -- left from different spec file ? :) fixed > OTHERS: > - if you already insist on proper English grammar when patching (which is > great!), do it proper;) > from the desktop file patch: > "Comment=PDF Merging, Rearranging, and Spliting" > ^ fixed in summary and .desktop files New Package CVS Request ======================= Package Name: pdfshuffler Short Description: PDF file merging, rearranging, and splitting Owners: fab Branches: F-9 F-10 InitialCC: cvs done. pdfshuffler-0.3.1-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pdfshuffler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1258 pdfshuffler-0.3.1-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update pdfshuffler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1271 https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1756 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1746 pdfshuffler-0.3.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. pdfshuffler-0.3.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: pdfshuffler New Branches: EL-5, EL-6 Owners: fab Git done (by process-git-requests). |