Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pdfshuffler.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pdfshuffler-0.3.1-1.fc10.src.rpm Project URL: https://sourceforge.net/projects/pdfshuffler/ Description: PDF-Shuffler is a small python-gtk application, which helps the user to merge or split pdf documents and rotate, crop and rearrange their pages using an interactive and intuitive graphical interface. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1094786 rpmlint output: [fab@laptop24 noarch]$ rpmlint pdfshuffler-0.3.1-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [fab@laptop24 SRPMS]$ rpmlint pdfshuffler-0.3.1-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUST: + rpmlint is silent + package name + spec file name - packaging guidelines - "The summary should be a short and concise description of the package" ? "A desktop diary" -- left from different spec file ? :) + Python guidelines: + defines %{python_sitelib} + builds egg from source + egg_info included + no unnecessary pyc/pyo + license (GPLv2+) ok, in COPYING as well in source files + spec file legible, English + source matches upstream (md5sum c59f3efcbc448c39fabbaac70c4237d4) + architectures ok (noarch) + builds in mock, no unnecessary BR + no need to ldconfig + locales ok (uses find_lang) + no library, hence no devel, static etc. + not relocatable + directories ownership ok + no dups in %files, proper %clean, %install + macros consistent + code and perm. content + %docs present + UTF-8 SHOULD: + license file + it works!:) OTHERS: - if you already insist on proper English grammar when patching (which is great!), do it proper;) from the desktop file patch: "Comment=PDF Merging, Rearranging, and Spliting" ^ Provided that you fix the summary (and the patch typo:) when importing, this package is APPROVED.
Thanks for the review and finding the typo. (In reply to comment #1) > - packaging guidelines > - "The summary should be a short and concise description of the package" > ? "A desktop diary" -- left from different spec file ? :) fixed > OTHERS: > - if you already insist on proper English grammar when patching (which is > great!), do it proper;) > from the desktop file patch: > "Comment=PDF Merging, Rearranging, and Spliting" > ^ fixed in summary and .desktop files
New Package CVS Request ======================= Package Name: pdfshuffler Short Description: PDF file merging, rearranging, and splitting Owners: fab Branches: F-9 F-10 InitialCC:
cvs done.
pdfshuffler-0.3.1-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pdfshuffler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1258
pdfshuffler-0.3.1-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update pdfshuffler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1271
https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1756 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1746
pdfshuffler-0.3.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
pdfshuffler-0.3.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: pdfshuffler New Branches: EL-5, EL-6 Owners: fab
Git done (by process-git-requests).