Bug 483501 (python-fiat)
| Summary: | Review Request: python-fiat - Generation of arbitrary order instances of the Lagrange elements | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jonathan.underwood, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-20 11:49:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 820660, 821727 | ||
|
Description
Fabian Affolter
2009-02-01 22:04:56 UTC
Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1098612 - rpmlint is NOT silent for SRPM and for RPM. python-fiat.src: W: invalid-license LGPL+ python-fiat.noarch: W: no-documentation python-fiat.noarch: W: invalid-license LGPL+ + source files match upstream url cc53f9d567ed71929cf94a9a83f3a027 FIAT-0.3.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + no %doc files present to install. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. Suggestions 1) License tag should be LGPLv2+ as described in Licensing page as "A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include. Note that this is LGPLv2+, not LGPL+, because version 2 was the first version of LGPL. " 2) you should ask upstream to include license text file in next upstream release. APPROVED. Thanks for the explanation about the licenses. I will fix this before cvs import. New Package CVS Request ======================= Package Name: python-fiat Short Description: Generation of arbitrary order instances of the Lagrange elements Owners: fab Branches: F-9 F-10 InitialCC: cvs done. External Bug report about the license file for tracking reasons http://www.fenics.org/cgi-bin/bugzilla/show_bug.cgi?id=58 python-fiat-0.3.4-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update python-fiat'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1210 python-fiat-0.3.4-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-fiat'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1352 Was pushed to stable https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1210 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1352 Package Change Request ====================== Package Name: python-fiat New Branches: el6 Owners: jgu InitialCC: Git done (by process-git-requests). |