Bug 483692

Summary:	pc98_probe() hangs
Product:	[Fedora] Fedora	Reporter:	David Cantrell <dcantrell>
Component:	parted	Assignee:	Joel Andres Granados <jgranado>
Status:	CLOSED WORKSFORME	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	rawhide	CC:	clumens, jgranado
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-02-11 20:54:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Cantrell 2009-02-03 01:54:07 UTC

While working on the new pyparted, the system kept entering an infinite loop or crash of some sort.  Tracked it down to pc98_probe() in libparted/labels/pc98.c

The block the appears to be running in an infinite loop is:

/* check consistency */
empty = 1;
for (p = part_table.partitions;
     p < part_table.partitions + MAX_PART_COUNT;
     p++)
{    
    if (p->mid == 0 && p->sid == 0)
        continue; 
    empty = 0;
    if (!check_partition_consistency (dev, p))
        return 0;
}

For now I am just using a locally built libparted with --disable-pc98 so that I can keep going working on pyparted and syntax changes to anaconda.

Comment 1 Joel Andres Granados 2009-02-06 18:14:17 UTC

I've tested with upstream parted and can't see the issue.  My test consisted of getting the dev `dev = parted.getDevice("DEVICE")` and getting the disk `disk = parted.Disk(dev)`  With each (dev and disk) I pocked around and nothing failed.  Do you have a python script that shows the failure?  Additionally, its not out of the realm of possibility that the partition lay out might have something to do with this.  Can you also post what your partition looks like so I can make the test more accurate.  I think whatever `parted -l` spits out will be enough.

Comment 2 Chris Lumens 2009-02-11 20:54:41 UTC

We are no longer seeing this in testing pyparted.  Perhaps it was never really a bug to begin with?